From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Fill column indicator functionality
Date: Sat, 06 Apr 2019 22:07:05 +0300
Message-ID: <837ec79cme.fsf@gnu.org>
References: <835zrsd670.fsf@gnu.org> <20190405150404.bm2d6wjtivwyesek@Ergus>
	<83r2agbhwv.fsf@gnu.org> <20190405173010.snavjhxrmmufwp54@Ergus>
	<83h8bcb7ce.fsf@gnu.org> <20190405200319.jfwt7lgevas556id@Ergus>
	<834l7bbp9a.fsf@gnu.org> <83k1g79smt.fsf@gnu.org>
	<20190406152014.zykyiakddmwsmkko@Ergus>
	<83a7h39l8l.fsf@gnu.org> <20190406185936.ndw74l5ysowmoihf@Ergus>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="149311"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: Ergus <spacibba@aol.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 06 21:07:42 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hCqfF-000ck1-Sp
	for ged-emacs-devel@m.gmane.org; Sat, 06 Apr 2019 21:07:42 +0200
Original-Received: from localhost ([127.0.0.1]:58070 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hCqfE-0001UV-ME
	for ged-emacs-devel@m.gmane.org; Sat, 06 Apr 2019 15:07:40 -0400
Original-Received: from eggs.gnu.org ([209.51.188.92]:37142)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1hCqf2-0001UN-RB
	for emacs-devel@gnu.org; Sat, 06 Apr 2019 15:07:29 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44282)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1hCqf2-0001H5-Lt; Sat, 06 Apr 2019 15:07:28 -0400
Original-Received: from [176.228.60.248] (port=4762 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1hCqf0-0002f8-Hd; Sat, 06 Apr 2019 15:07:28 -0400
In-reply-to: <20190406185936.ndw74l5ysowmoihf@Ergus> (message from Ergus on
	Sat, 6 Apr 2019 20:59:36 +0200)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:235041
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/235041>

> Date: Sat, 6 Apr 2019 20:59:36 +0200
> From: Ergus <spacibba@aol.com>
> Cc: emacs-devel@gnu.org
> 
> I am wondering if there is a way to put conditionals there, because the
> redisplay needs to be triggered only if one of the variables is already
> non-nil and we need to redisplay if we change fill-column only if
> display-fill-column-indicator-column is t. Similar thing should happen
> for display-line-numbers right?

I don't see why we should bother.  These variables change only rarely,
so it isn't like they will trigger redisplay frequent enough to be a
problem.

Btw, if you mean you added display-fill-column-indicator-* variables
to the list in frame.el, I don't think I see that.  Did I miss
something?