From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Add support for base64url variant Date: Wed, 22 May 2019 10:43:56 +0300 Message-ID: <837eaj7x37.fsf@gnu.org> References: <87pnobiglo.fsf@killashandra.ballybran.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="24186"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Pierre =?iso-8859-1?Q?T=E9choueyres?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 22 09:44:00 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hTLup-0006A7-6o for ged-emacs-devel@m.gmane.org; Wed, 22 May 2019 09:43:59 +0200 Original-Received: from localhost ([127.0.0.1]:37847 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTLun-0006Z6-US for ged-emacs-devel@m.gmane.org; Wed, 22 May 2019 03:43:57 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTLuh-0006Yo-8F for emacs-devel@gnu.org; Wed, 22 May 2019 03:43:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:32990) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTLug-0005tL-Qc; Wed, 22 May 2019 03:43:50 -0400 Original-Received: from [176.228.60.248] (port=2918 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hTLug-0003Vb-AQ; Wed, 22 May 2019 03:43:50 -0400 In-reply-to: <87pnobiglo.fsf@killashandra.ballybran.fr> (message from Pierre =?iso-8859-1?Q?T=E9choueyres?= on Wed, 22 May 2019 00:32:19 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236884 Archived-At: > From: Pierre Téchoueyres > Date: Wed, 22 May 2019 00:32:19 +0200 > > I'm actually working on an emacs library to work with JWT (JSON Web > Token) as described in RFC 7519 / 7797. To achive that I must use an > variant of base 64 encoding named base64url as described in RFC4648. > > Actually Emacs doesn't provide this variant. I've attached an attempt > to implement it at C level. > > I'm avare that my patch is far from perfect and I would welcome any > help or comments to improve it. Thanks, but please avoid posting such large patches as long as you don't have a copyright assignment for Emacs on file. That's because just by reading the patch, people will remember some of the implementation, and will then have hard time to come up with a different one, should your copyright assignment paperwork not come through. If you'd like to sign the forms, I will send them to you. Then we could revisit the patch when the legal paperwork is done. Thanks again for working on this.