From: Eli Zaretskii <eliz@gnu.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: contovob@tcd.ie, ohwoeowho@gmail.com, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master fd54102: * lisp/files.el (file-size-function): New defcustom
Date: Mon, 22 Jul 2019 20:29:41 +0300 [thread overview]
Message-ID: <837e8aq8oq.fsf@gnu.org> (raw)
In-Reply-To: <B53B40CA-AFF5-4C32-A67C-277FA1F44FB6@acm.org> (message from Mattias Engdegård on Mon, 22 Jul 2019 17:26:10 +0200)
> From: Mattias Engdegård <mattiase@acm.org>
> Date: Mon, 22 Jul 2019 17:26:10 +0200
> Cc: Oleh Krehel <ohwoeowho@gmail.com>, Eli Zaretskii <eliz@gnu.org>,
> emacs-devel <emacs-devel@gnu.org>
>
> Agreed, and this defcustom (file-size-function) has a much more general-sounding name and description than merited by its effects (which are limited to the "available disk space" number in Dired and that's it).
>
> Attached is a minimal clean-up which remedies some of the flaws, but perhaps we should instead roll back the defcustom and all related changes entirely until a cohesive proposal is forthcoming, as per your and Eli's comments. Fighting it out in the source isn't really going to be productive.
Thanks. Please consider calling this out in NEWS and maybe also in
the ELisp manual.
next prev parent reply other threads:[~2019-07-22 17:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190719165710.17673.32987@vcs0.savannah.gnu.org>
[not found] ` <20190719165711.741F1206A7@vcs0.savannah.gnu.org>
2019-07-20 16:53 ` [Emacs-diffs] master fd54102: * lisp/files.el (file-size-function): New defcustom Basil L. Contovounesios
2019-07-20 17:06 ` Eli Zaretskii
2019-07-20 17:38 ` Oleh Krehel
2019-07-20 17:45 ` Eli Zaretskii
2019-07-20 17:50 ` Oleh Krehel
2019-07-20 17:56 ` Eli Zaretskii
2019-07-20 18:50 ` Basil L. Contovounesios
2019-07-22 15:26 ` Mattias Engdegård
2019-07-22 16:15 ` Oleh Krehel
2019-07-22 20:14 ` Stefan Monnier
2019-07-26 10:43 ` Mattias Engdegård
2019-07-26 14:39 ` Basil L. Contovounesios
2019-07-26 21:39 ` Mattias Engdegård
2019-07-22 17:29 ` Eli Zaretskii [this message]
2019-07-20 17:30 ` Mattias Engdegård
2019-07-20 18:48 ` Basil L. Contovounesios
2019-07-20 19:06 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837e8aq8oq.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=mattiase@acm.org \
--cc=ohwoeowho@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).