From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Redisplay slower in Emacs 28 than Emacs 27 Date: Tue, 08 Dec 2020 18:53:28 +0200 Message-ID: <837dps6xyv.fsf@gnu.org> References: <877dptiro7.fsf@gnus.org> <87pn3lhcdd.fsf@gnus.org> <878sa9hbe2.fsf@gnus.org> <877dptfvae.fsf@gnus.org> <83czzl8qwu.fsf@gnu.org> <87sg8h78s8.fsf@gnus.org> <837dpt8lk5.fsf@gnu.org> <87pn3kjssr.fsf@gnus.org> <83im9c70vu.fsf@gnu.org> <87im9cfeej.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="307"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ghe@sdf.org, emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 08 18:10:58 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmgVu-000AWa-2m for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Dec 2020 18:10:58 +0100 Original-Received: from localhost ([::1]:45184 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmgVt-0001rY-3f for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Dec 2020 12:10:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40302) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmgF6-0003vm-2B for emacs-devel@gnu.org; Tue, 08 Dec 2020 11:53:36 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54144) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmgF5-0000z4-I2; Tue, 08 Dec 2020 11:53:35 -0500 Original-Received: from [176.228.60.248] (port=2627 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kmgF4-00049Q-49; Tue, 08 Dec 2020 11:53:34 -0500 In-Reply-To: <87im9cfeej.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 08 Dec 2020 17:31:16 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:260569 Archived-At: > From: Lars Ingebrigtsen > Cc: ghe@sdf.org, emacs-devel@gnu.org > Date: Tue, 08 Dec 2020 17:31:16 +0100 > > So moving to Fequal is fine if we decide to have the Emacs 27 caching > semantics. > > However, if we move to EQ semantics, the real speedup is that we don't > have to call sxhash(img) on all the images -- and that's a slow > operation, because it'll call hash_string on all the string contents, > and if you have a large :data image, it'll compute that every time Emacs > decides to redisplay that image. I don't think I follow: since an image spec can (and usually does) include a file name, how can we use EQ? That would mean identical file names will cause us to think an image isn't cached, right? Or what am I missing?