From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Consistent face for keys in *Help* and `substitute-command-keys'
Date: Fri, 05 Mar 2021 22:15:26 +0200
Message-ID: <837dmlxspt.fsf@gnu.org>
References: <CADwFkmkj2M=s9gbjFzpzKpbgUrp-qcBf7zPNCeBUAxzkwo-ULQ@mail.gmail.com>
 <87h7m5iagw.fsf@gnus.org>
 <CADwFkmk-B+a0Ls++kPS0RnhjHAiGdfc_63t8TAa1wuBRZ35GpQ@mail.gmail.com>
 <83blc9tnvz.fsf@gnu.org>
 <CADwFkm=ynKGGFyMX72mA1j5Wi+ShHuO2Aa9RAp1wFV7mKtXANg@mail.gmail.com>
 <83y2fcrzkt.fsf@gnu.org>
 <CADwFkm=8pOqpgCgDSc2zVbGiMxH7YsCK75pufHLJgwyDuJ6wjw@mail.gmail.com>
 <831rd4romg.fsf@gnu.org>
 <CADwFkmk5PVhWNqaaKxBuzYK9szTUSXqgTuo86ZPozmNeS048kw@mail.gmail.com>
 <83zgzsq7xn.fsf@gnu.org>
 <CADwFkmmwP854hVbN6Q8uV0Wmp_8Ytz17BneWYNge27Si0y3AmA@mail.gmail.com>
 <83v9afriqp.fsf@gnu.org>
 <CADwFkmm8BbdwFmprCE0m-Tr8CsCeo0g9s5CuORa9z8_mc6gefQ@mail.gmail.com>
 <83zgzjhvdn.fsf@gnu.org>
 <CADwFkm=iPeaSD3E7meeifvi7QDAnQ9yqQbe5JHe2BiQaiSaw3g@mail.gmail.com>
 <83a6rhxwah.fsf@gnu.org>
 <CADwFkmnNPjy=q8W399518w0jhUJZJrwpNUBA_gGQUb==yeBr2g@mail.gmail.com>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="16238"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: larsi@gnus.org, emacs-devel@gnu.org
To: Stefan Kangas <stefan@marxist.se>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 05 21:16:44 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1lIGsN-00044M-SL
	for ged-emacs-devel@m.gmane-mx.org; Fri, 05 Mar 2021 21:16:43 +0100
Original-Received: from localhost ([::1]:60252 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1lIGsM-0005mb-UQ
	for ged-emacs-devel@m.gmane-mx.org; Fri, 05 Mar 2021 15:16:42 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49830)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1lIGrS-0005Fa-1w
 for emacs-devel@gnu.org; Fri, 05 Mar 2021 15:15:46 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49972)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1lIGrR-0008Lc-7R; Fri, 05 Mar 2021 15:15:45 -0500
Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4066
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1lIGrM-0004oW-G3; Fri, 05 Mar 2021 15:15:44 -0500
In-Reply-To: <CADwFkmnNPjy=q8W399518w0jhUJZJrwpNUBA_gGQUb==yeBr2g@mail.gmail.com>
 (message from Stefan Kangas on Fri, 5 Mar 2021 13:28:57 -0600)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:266040
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/266040>

> From: Stefan Kangas <stefan@marxist.se>
> Date: Fri, 5 Mar 2021 13:28:57 -0600
> Cc: larsi@gnus.org, emacs-devel@gnu.org
> 
> > This would take care of the conflicting colors, but that's not the
> > original problem which caused us to talk about tooltips.  The original
> > problem was that someone could customize the help-key-binding face to
> > specify size as well.  What do you see then?
> 
> It works as expected also when you specify :height.

"As expected" meaning what in this case?  Does the different size show
or doesn't it?

> > This should have a comment explaining why we use a non-nil APPEND
> > argument.
> 
> Fixed in the attached.

Thanks.