From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [External] : Re: [PATCH] When deleting in bookmark menu, prompt for confirmation. Date: Wed, 26 May 2021 14:59:44 +0300 Message-ID: <837djlbt8v.fsf@gnu.org> References: <87a6pcqy7s.fsf@red-bean.com> <83czu86o46.fsf@gnu.org> <835z006jpl.fsf@gnu.org> <87im3z3f8f.fsf@red-bean.com> <83zgxb67g2.fsf@gnu.org> <87mtt9sqh4.fsf@red-bean.com> <87czu58uso.fsf@gnus.org> <878s4tq8e6.fsf@red-bean.com> <874kfguail.fsf@red-bean.com> <875yzwtkuj.fsf@gmail.com> <87lf8prm2f.fsf@gmail.com> <83eeeg8ez9.fsf@gnu.org> <87h7jboirj.fsf@red-bean.com> <83cztz7nvd.fsf@gnu.org> <87wnrn4bld.fsf@red-bean.com> <83cztfc8vh.fsf@gnu.org> <87fsyatvcj.fsf@red-bean.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36438"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, orontee@gmail.com, monnier@iro.umontreal.ca, drew.adams@oracle.com, emacs-devel@gnu.org To: Karl Fogel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 26 14:00:52 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llsDT-0009Hk-Vw for ged-emacs-devel@m.gmane-mx.org; Wed, 26 May 2021 14:00:51 +0200 Original-Received: from localhost ([::1]:38424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llsDT-0000An-0Z for ged-emacs-devel@m.gmane-mx.org; Wed, 26 May 2021 08:00:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60126) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llsCO-0007ka-Bq for emacs-devel@gnu.org; Wed, 26 May 2021 07:59:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59758) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llsCN-0008Jh-CD; Wed, 26 May 2021 07:59:43 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4205 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llsCM-0005p7-Va; Wed, 26 May 2021 07:59:43 -0400 In-Reply-To: <87fsyatvcj.fsf@red-bean.com> (message from Karl Fogel on Tue, 25 May 2021 15:24:44 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269913 Archived-At: > From: Karl Fogel > Cc: orontee@gmail.com, drew.adams@oracle.com, larsi@gnus.org, > monnier@iro.umontreal.ca, emacs-devel@gnu.org > Date: Tue, 25 May 2021 15:24:44 -0500 > > >Given what you wrote, and what bookmark-load does with the prefix > >argument, I think it is better to say that explicitly in > >bookmark-bmenu-load's doc string, since you only need a single > >quite > >simple sentence to say that, whereas the doc strong of > >bookmark-load > >is quite long. > > Well, now that I've done it, I think your way is an improvement -- > although it turned out to be slightly more doc change than I > expected. Revised patch attached for review. LGTM, thanks.