From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Use define_error outside of json.c
Date: Tue, 27 Jul 2021 17:01:21 +0300
Message-ID: <837dhbvosu.fsf@gnu.org>
References: <62D33934-5F12-4E87-8E56-28FD8DDB138A@gmail.com>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="21836"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: Yuan Fu <casouri@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 27 16:03:40 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1m8NgK-0005WQ-NP
	for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Jul 2021 16:03:40 +0200
Original-Received: from localhost ([::1]:59118 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1m8NgJ-0001LO-PL
	for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Jul 2021 10:03:39 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57692)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1m8NeD-0007bn-6h
 for emacs-devel@gnu.org; Tue, 27 Jul 2021 10:01:29 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47616)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1m8NeC-0002Xs-So; Tue, 27 Jul 2021 10:01:28 -0400
Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1987
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1m8NeA-0001XI-2z; Tue, 27 Jul 2021 10:01:28 -0400
In-Reply-To: <62D33934-5F12-4E87-8E56-28FD8DDB138A@gmail.com> (message from
 Yuan Fu on Mon, 26 Jul 2021 16:01:30 -0400)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:271694
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/271694>

> From: Yuan Fu <casouri@gmail.com>
> Date: Mon, 26 Jul 2021 16:01:30 -0400
> 
> I find define_error in json.c very useful and want to use it outside of json.c, where should I move the declaration and definition?

Move it to eval.c and remove the 'static' qualifier from it.  Then add
a prototype to lisp.h.