From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: vcursor.el: `vcursor-copy-word` and `vcursory-copy-line` not working as expected Date: Wed, 24 Nov 2021 14:27:01 +0200 Message-ID: <837dcxagdm.fsf@gnu.org> References: <87y25emzyo.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4287"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Narendra Joshi Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 24 13:28:11 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mprNc-0000da-Lw for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Nov 2021 13:28:04 +0100 Original-Received: from localhost ([::1]:54386 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mprNa-0002VD-K3 for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Nov 2021 07:28:02 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57542) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mprMd-0001bz-U3 for emacs-devel@gnu.org; Wed, 24 Nov 2021 07:27:03 -0500 Original-Received: from [2001:470:142:3::e] (port=55584 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mprMd-0003Rc-KY; Wed, 24 Nov 2021 07:27:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qbRPop3AuqkfvEynuGcg3yrS5qZ1T7z6U41gm17yH3o=; b=YN0gfFPBNJI+ P+9hzz+Lq8CYCsxu6E4mg/xC/eCCNgtIWjrHRNvVUf6qowb0qpBu76Q1FCIxm50WeYzAoc6AdC5bq iQ/iZmZyQJl2xPmy4rDhdB+v5geCck72esH0fkRm89Ku/AH3kM1agWAPjphh57YyLHDnsWpj18by1 IOSqdlkH0sFhdX7zvwL+ktvuXmQaGdq5qH+W8W0Xnvj1khwzpyzpDUfnnmWVfQd3+IjHsm3PXTwUv I6G6nzbm9kynhVGvf3O9TGsvbpUdQ7CIUu+D/pxo1BkTigoHClnpSgVHde06yvVyJrkDZ33oQV5kR +53sxqsWQe4c3+zar3ocTA==; Original-Received: from [87.69.77.57] (port=4680 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mprMd-0005oC-9w; Wed, 24 Nov 2021 07:27:03 -0500 In-Reply-To: <87y25emzyo.fsf@gmail.com> (message from Narendra Joshi on Tue, 23 Nov 2021 20:30:55 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:279992 Archived-At: > From: Narendra Joshi > Date: Tue, 23 Nov 2021 20:30:55 +0100 > > I think `vcursor.el` has a bug that causes `point` (the real cursor) to > move to where the virtual cursor is whenever `vcursor-copy-{word,line}` > are used. > > We need to wrap the `goto-char` call below in something like > `save-excursion`: Thanks, but I think save-excursion should be deeper, immediately befor we call goto-char. It is not good practice to change buffers inside save-excursion.