From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 501e2096d6: Fix some issues with a recent change Date: Mon, 27 Dec 2021 05:27:08 +0200 Message-ID: <837dbqohgz.fsf@gnu.org> References: <164051393145.21885.8315099612759503047@vcs2.savannah.gnu.org> <20211226101851.B61E5C04DCC@vcs2.savannah.gnu.org> <83bl13nsav.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26378"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 27 04:28:07 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n1ggB-0006hM-4T for ged-emacs-devel@m.gmane-mx.org; Mon, 27 Dec 2021 04:28:07 +0100 Original-Received: from localhost ([::1]:38516 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n1gg8-0001Tt-E5 for ged-emacs-devel@m.gmane-mx.org; Sun, 26 Dec 2021 22:28:04 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54972) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1gez-0000lE-3M for emacs-devel@gnu.org; Sun, 26 Dec 2021 22:26:53 -0500 Original-Received: from [2001:470:142:3::e] (port=44258 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1gey-0006Kw-O8; Sun, 26 Dec 2021 22:26:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=sSNeC5fUhRROwjnUOgKI6SGWOKhW4APf5r57xkRT+Sw=; b=XeBXQNnijZQW o5IDqFcctC2/LPQ3BfAQDa47B53YRbYB5/ykcmtARwJQIEczB/PWhR0uQHkadICz+0WZm2V8Mzkxy cG9uFOvfkJ4VO7QIlkCUS4jChyYoDH2GyorW896QVGmzslmLXM87zeDBHtw3srjYTw1eh25WEiBBp gfhvmYpYKlWbeSmaidJMQjvJw3ij9OPE6v/RxqwuUdR3oBZZsv+80lbIfmIqXYBeNnZ6eNKSggdJB DL6LfC4iN8Q6BchhSpLuvnxIuX9kz+hqB55HETiCAXGIWpVtRRUSbk0Kq5PqYgQJV2wfE64Lqc3y6 wRd5aFSb8aR7iHnNaan0Pw==; Original-Received: from [87.69.77.57] (port=4135 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1gey-0002L4-IS; Sun, 26 Dec 2021 22:26:52 -0500 In-Reply-To: (message from Stefan Monnier on Sun, 26 Dec 2021 16:12:37 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:283376 Archived-At: > From: Stefan Monnier > Cc: luangruo@yahoo.com, emacs-devel@gnu.org > Date: Sun, 26 Dec 2021 16:12:37 -0500 > > >> Please include some more info in the first line of your commits, such as > >> the relevant file(s). > > > > According to the format we use, the file(s) don't have to be mentioned > > in the first line. Given enough files, that is simply impossible. > > Please re-read the `Subject:` of this thread and tell me if you think it > holds any useful information other than "master 501e2096d6"? I find it entirely pertinent. Changes aren't supposed to be judged by reading the emacs-diffs mailing list, they are supposed to be judged by looking at the VCS logs, in which case the "recent change" part will tell you all you need to know. Once again, personal workflows should not affect our coding conventions.