unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master 1d681a5700: Add test for bug#56078 fix
       [not found] ` <20220621021220.E1FCFC01686@vcs2.savannah.gnu.org>
@ 2022-06-21  8:10   ` Robert Pluim
  2022-06-21 10:16     ` Po Lu
  0 siblings, 1 reply; 4+ messages in thread
From: Robert Pluim @ 2022-06-21  8:10 UTC (permalink / raw)
  To: emacs-devel; +Cc: Po Lu

>>>>> On Mon, 20 Jun 2022 22:12:20 -0400 (EDT), Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> said:

 
    Po> +(ert-deftest dnd-tests-open-remote-url ()
    Po> +  ;; Expensive test to make sure opening an FTP URL during
    Po> +  ;; drag-and-drop works.
    Po> +  :tags '(:expensive-test)
    Po> +  ;; Don't run this test if the FTP server isn't reachable.
    Po> +  (skip-unless (and (fboundp 'network-lookup-address-info)
    Po> +                    (network-lookup-address-info "ftp.gnu.org")))
    Po> +  ;; Make sure bug#56078 doesn't happen again.
    Po> +  (let ((url "ftp://anonymous@ftp.gnu.org/")
    Po> +        ;; This prints a bunch of annoying spaces to stdout.
    Po> +        (inhibit-message t))
    Po> +    (should (prog1 t (dnd-open-remote-url url 'private)))))
    Po> +
    Po>  (provide 'dnd-tests)
    Po>  ;;; dnd-tests.el ends here

I thought that the test suite 'phoning home' was frowned upon (and
which platform doesnʼt have network-lookup-address-info?)

Robert
-- 



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: master 1d681a5700: Add test for bug#56078 fix
  2022-06-21  8:10   ` master 1d681a5700: Add test for bug#56078 fix Robert Pluim
@ 2022-06-21 10:16     ` Po Lu
  2022-06-21 10:23       ` Robert Pluim
  0 siblings, 1 reply; 4+ messages in thread
From: Po Lu @ 2022-06-21 10:16 UTC (permalink / raw)
  To: Robert Pluim; +Cc: emacs-devel

Robert Pluim <rpluim@gmail.com> writes:

> I thought that the test suite 'phoning home' was frowned upon

Hmm, any better ideas?

> (and which platform doesnʼt have network-lookup-address-info?)

MS-DOS.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: master 1d681a5700: Add test for bug#56078 fix
  2022-06-21 10:16     ` Po Lu
@ 2022-06-21 10:23       ` Robert Pluim
  2022-06-21 12:11         ` Eli Zaretskii
  0 siblings, 1 reply; 4+ messages in thread
From: Robert Pluim @ 2022-06-21 10:23 UTC (permalink / raw)
  To: Po Lu; +Cc: emacs-devel

>>>>> On Tue, 21 Jun 2022 18:16:21 +0800, Po Lu <luangruo@yahoo.com> said:

    Po> Robert Pluim <rpluim@gmail.com> writes:
    >> I thought that the test suite 'phoning home' was frowned upon

    Po> Hmm, any better ideas?

I thought bug 56078 was about the filename not being parsed correctly,
not about the transfer failing?

    >> (and which platform doesnʼt have network-lookup-address-info?)

    Po> MS-DOS.

Hmm, OK. I wonder what percentage of our test suite actually runs
correctly there.

Robert
-- 



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: master 1d681a5700: Add test for bug#56078 fix
  2022-06-21 10:23       ` Robert Pluim
@ 2022-06-21 12:11         ` Eli Zaretskii
  0 siblings, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2022-06-21 12:11 UTC (permalink / raw)
  To: Robert Pluim; +Cc: luangruo, emacs-devel

> From: Robert Pluim <rpluim@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Tue, 21 Jun 2022 12:23:41 +0200
> 
>     Po> MS-DOS.
> 
> Hmm, OK. I wonder what percentage of our test suite actually runs
> correctly there.

I don't know, but it should be easy to say skip-unless...



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-06-21 12:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <165577754064.962.4980616621155170793@vcs2.savannah.gnu.org>
     [not found] ` <20220621021220.E1FCFC01686@vcs2.savannah.gnu.org>
2022-06-21  8:10   ` master 1d681a5700: Add test for bug#56078 fix Robert Pluim
2022-06-21 10:16     ` Po Lu
2022-06-21 10:23       ` Robert Pluim
2022-06-21 12:11         ` Eli Zaretskii

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).