From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: New library wallpaper.el pushed to master Date: Tue, 13 Sep 2022 19:54:22 +0300 Message-ID: <837d2743lt.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="640"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 13 18:56:12 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oY9Cl-000AUL-Vd for ged-emacs-devel@m.gmane-mx.org; Tue, 13 Sep 2022 18:56:12 +0200 Original-Received: from localhost ([::1]:53560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oY9Ck-0007rv-Ty for ged-emacs-devel@m.gmane-mx.org; Tue, 13 Sep 2022 12:56:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45574) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oY9BC-00071f-RA for emacs-devel@gnu.org; Tue, 13 Sep 2022 12:54:34 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59078) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oY9BC-0001i3-I6; Tue, 13 Sep 2022 12:54:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=yf5u5r5AmDzOqd/bAHqrnXt/Hmpd7to/KErtE7MCJIU=; b=UQlPrhcg9Ovf kTPFvS5hvb4zt6QcUJFtAt+0HoHR4eBgXAwRw6IRvKp9gN4JRgI+QvZ/R6UT0vNEdWaCU4yjps5Kt A+zek16n3ZUcrEw1QMw6WIj5Jo20IipL//DtKAgNRaJfq/qOP/zRX110gTSMHq7bdaj+4FKsp1xmQ 0yMwkqpvDvG94DKUaiVc5nN6rN3nwA7kLfIKkZ+mUzMyVYzXyRNEZY6XYOhZQGWj0+YwFdoQzYCoz UGVRWMIMw+g3mGAhEBm2akj5CEkKX/qCvtT+kzKSnmdqeLSfb3h0CXMe+eX3TJJq2tnXYhv+TwTzH 3HsgGL02XdWexN8t1oZPdQ==; Original-Received: from [87.69.77.57] (port=4430 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oY9BC-0003Md-09; Tue, 13 Sep 2022 12:54:34 -0400 In-Reply-To: (message from Stefan Kangas on Tue, 13 Sep 2022 12:28:12 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295265 Archived-At: > From: Stefan Kangas > Date: Tue, 13 Sep 2022 12:28:12 -0400 > > I have now pushed the new library wallpaper.el and changed thumbs.el and > image-dired.el to use it. It has the new command `wallpaper-set', and > the user option `wallpaper-commands' to control it. > > I don't expect it to not work on anything but GNU/Linux for now, but > patches and suggestions are obviously very welcome. (I hope that it > will be easy to add checks for different environments by adding new > `cl-defgeneric's.) Thanks. >From casual reading, the code seems to be heavily biased towards the assumption that setting a wallpaper requires invoking an external program. What about systems where this can be done by calling an API (i.e., via a special-purpose Emacs primitive)? Would you please amend the code to make the feature more easily extended to use such methods? In addition, are you sure it is a good idea to have a defcustom whose value is list of lists of strings? Users who wish to customize this will have hard time, unless they are very proficient ion Emacs Lisp. Can we come up with a defcustom that is easier to customize?