From: Eli Zaretskii <eliz@gnu.org>
To: Eshel Yaron <me@eshelyaron.com>,
Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Question about eval and compile-command
Date: Thu, 03 Aug 2023 12:56:45 +0300 [thread overview]
Message-ID: <837cqcxxcy.fsf@gnu.org> (raw)
In-Reply-To: <m1bkfobhj1.fsf@eshelyaron.com> (message from Eshel Yaron on Thu, 03 Aug 2023 12:29:38 +0300)
> From: Eshel Yaron <me@eshelyaron.com>
> Date: Thu, 03 Aug 2023 12:29:38 +0300
>
> Hi all,
>
> I'm curious as to why `compile` and `recompile` use `eval` to evaluate
> the value of `compile-command`. AFAICT since commit
> 5b6858da26e4e6671ee93b67b921a86309b3d6a2 (July 19 2001), these commands
> evaluate `compile-command`, as if it's expected to be an expression that
> evaluates to a string rather than just a plain string.
>
> The commit message says:
>
> (compilation-parse-errors): `linenum' might return a this-error using
> the alternative format (a pair of markers).
>
> But I don't quite understand how that relates to `compile-command`.
It doesn't, it describes the change in compilation-parse-errors.
It looks like Stefan added the 'eval' calls as a minor cleanup and not
as part of the change itself. Stefan, any chance you remember why you
added the 'eval' calls?
next prev parent reply other threads:[~2023-08-03 9:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 9:29 Question about eval and compile-command Eshel Yaron
2023-08-03 9:56 ` Eli Zaretskii [this message]
2023-08-03 15:14 ` Stefan Monnier
2023-08-03 16:23 ` Eshel Yaron
2023-08-03 17:24 ` Stefan Monnier
2023-08-03 20:02 ` Philip Kaludercic
2023-08-03 20:39 ` Stefan Monnier
2023-08-03 21:14 ` Andreas Schwab
2023-08-03 21:35 ` [External] : " Drew Adams
2023-08-04 5:40 ` Eli Zaretskii
2023-08-04 6:51 ` Andreas Schwab
2023-08-04 7:00 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837cqcxxcy.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=me@eshelyaron.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).