From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Seiji Zenitani Newsgroups: gmane.emacs.devel Subject: [OS X] Title bar icon Date: Sun, 26 Aug 2007 11:55:11 -0400 Message-ID: <8370BFE3-71F2-4848-9E05-A16C06CD1C2D@mac.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v752.3) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1188143788 8901 80.91.229.12 (26 Aug 2007 15:56:28 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 26 Aug 2007 15:56:28 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Aug 26 17:56:25 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IPKTQ-0004YU-Mf for ged-emacs-devel@m.gmane.org; Sun, 26 Aug 2007 17:56:24 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IPKTQ-000611-8k for ged-emacs-devel@m.gmane.org; Sun, 26 Aug 2007 11:56:24 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IPKTL-0005zE-Ki for emacs-devel@gnu.org; Sun, 26 Aug 2007 11:56:19 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IPKTJ-0005vS-IB for emacs-devel@gnu.org; Sun, 26 Aug 2007 11:56:18 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IPKTJ-0005vH-BZ for emacs-devel@gnu.org; Sun, 26 Aug 2007 11:56:17 -0400 Original-Received: from smtpout.mac.com ([17.250.248.185]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IPKTI-0003wn-OG for emacs-devel@gnu.org; Sun, 26 Aug 2007 11:56:17 -0400 Original-Received: from mac.com (smtpin05-en2 [10.13.10.150]) by smtpout.mac.com (Xserve/smtpout15/MantshX 4.0) with ESMTP id l7QFuE0g010178 for ; Sun, 26 Aug 2007 08:56:14 -0700 (PDT) Original-Received: from [10.0.1.199] (c-68-55-160-31.hsd1.md.comcast.net [68.55.160.31]) (authenticated bits=0) by mac.com (Xserve/smtpin05/MantshX 4.0) with ESMTP id l7QFuEik010826 for ; Sun, 26 Aug 2007 08:56:14 -0700 (PDT) X-Mailer: Apple Mail (2.752.3) X-Detected-Kernel: FreeBSD 4.7-5.2 (or MacOS X 10.2-10.4) (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:77219 Archived-At: Hi, When visiting a file, the Carbon (OS X) port displays a small proxy icon in the window title bar, like other OS X applications. However, the proxy icon disappears when the cursor temporary visits the mini buffer (i.e. saving the buffer to another file by C-x C-w), often enough to attract the user's attention. I don't think it is necessary to update the proxy icon in the case of the mini buffer, because the mini buffer usually receives the user's input or shows a message. How about disabling the update_proxy_icon function in the mini buffer? I use the following patch in order to modify the above behavior. Seiji Zenitani zenitani@mac.com --- src/macfns.c.orig 2007-07-25 23:05:09.000000000 -0400 +++ src/macfns.c 2007-07-28 22:34:13.000000000 -0400 @@ -2111,16 +2138,15 @@ return; w = XWINDOW (FRAME_SELECTED_WINDOW (f)); + if (MINI_WINDOW_P (w)) + return; + modified_p = (BUF_SAVE_MODIFF (XBUFFER (w->buffer)) < BUF_MODIFF (XBUFFER (w->buffer))); if (windows_or_buffers_changed - /* Minibuffer modification status shown in the close button is - confusing. */ - || (!MINI_WINDOW_P (w) - && (modified_p != !NILP (w->last_had_star)))) + || (modified_p != !NILP (w->last_had_star))) { - SetWindowModified (FRAME_MAC_WINDOW (f), - !MINI_WINDOW_P (w) && modified_p); + SetWindowModified (FRAME_MAC_WINDOW (f), modified_p); mac_update_proxy_icon (f); } #endif