From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bill Wohler Newsgroups: gmane.mail.mh-e.devel,gmane.emacs.devel Subject: Re: mh-e/mh-acros.el advices `require' incorrectly Date: Fri, 13 Jan 2006 14:11:49 -0800 Organization: Newt Software Message-ID: <837.1137190309@olgas.newt.com> References: NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1137190348 29118 80.91.229.2 (13 Jan 2006 22:12:28 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 13 Jan 2006 22:12:28 +0000 (UTC) Cc: emacs-devel@gnu.org, mh-e-devel@lists.sourceforge.net Original-X-From: mh-e-devel-admin@lists.sourceforge.net Fri Jan 13 23:12:21 2006 Return-path: Envelope-to: gmmd-mh-e-devel@m.gmane.org Original-Received: from lists-outbound.sourceforge.net ([66.35.250.225]) by ciao.gmane.org with esmtp (Exim 4.43) id 1ExX9T-0000ua-Ow for gmmd-mh-e-devel@m.gmane.org; Fri, 13 Jan 2006 23:12:08 +0100 Original-Received: from sc8-sf-list1-b.sourceforge.net (sc8-sf-list1-b.sourceforge.net [10.3.1.7]) by sc8-sf-spam1.sourceforge.net (Postfix) with ESMTP id F32EA89098; Fri, 13 Jan 2006 14:12:06 -0800 (PST) Original-Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1ExX9J-0007lw-K0 for mh-e-devel@lists.sourceforge.net; Fri, 13 Jan 2006 14:11:57 -0800 Original-Received: from 69-93-192-76.acornhosting.net ([69.93.192.76] helo=tassie.newt.com) by mail.sourceforge.net with esmtp (Exim 4.44) id 1ExX9H-0007nx-8M for mh-e-devel@lists.sourceforge.net; Fri, 13 Jan 2006 14:11:57 -0800 Original-Received: from olgas.newt.com (m190e36d0.tmodns.net [208.54.14.25]) by tassie.newt.com (Postfix) with ESMTP id 7C52A2D401E; Fri, 13 Jan 2006 14:11:54 -0800 (PST) Original-Received: by olgas.newt.com (Postfix, from userid 1000) id 5755E16FD9; Fri, 13 Jan 2006 14:11:49 -0800 (PST) Original-Received: from olgas.newt.com (localhost [127.0.0.1]) by olgas.newt.com (Postfix) with ESMTP id 534E116F4D; Fri, 13 Jan 2006 14:11:49 -0800 (PST) Original-To: "Drew Adams" In-Reply-To: "Drew Adams"'s message of Fri, 13 Jan 2006 13:04:15 PST. X-Mailer: MH-E 7.85+cvs; nmh 1.1; GNU Emacs 22.0.50.1 X-Image-URL: http://www.newt.com/wohler/images/bill-diving.png Mail-Followup-To: emacs-devel@gnu.org, mh-e-devel@lists.sourceforge.net X-Spam-Score: 1.0 (+) X-Spam-Report: Spam Filtering performed by sourceforge.net. See http://spamassassin.org/tag/ for more details. Report problems to http://sf.net/tracker/?func=add&group_id=1&atid=200001 1.0 FORGED_RCVD_HELO Received: contains a forged HELO Original-Sender: mh-e-devel-admin@lists.sourceforge.net Errors-To: mh-e-devel-admin@lists.sourceforge.net X-BeenThere: mh-e-devel@lists.sourceforge.net X-Mailman-Version: 2.0.9-sf.net Precedence: bulk List-Unsubscribe: , List-Id: Forum for the MH-E developers List-Post: List-Help: List-Subscribe: , List-Archive: X-Original-Date: Fri, 13 Jan 2006 14:11:49 -0800 Xref: news.gmane.org gmane.mail.mh-e.devel:11268 gmane.emacs.devel:49029 Archived-At: Drew Adams wrote: > > The origianl `require' returns FEATURE even if it is already > > provided, but the adviced `require' returns nil in such a > > case. So, once mh-acros.el is loaded, a code depending on > > the return value of `require' stops working. > > > > How about this change? > > What do you (and others) think about this? > > Besides the fact that we shouldn't use defadvice in vanilla Emacs code, I > don't think we should change the return value of `require' at all. It has > acted this way for a very long time, and there is undoubtedly code that > depends on this behavior (at least some external libraries). Besides, we > certainly should not make such a change just before a release. Unless you load MH-E, require does not change. If I understand correctly, Kanichi's patch addresses your concern (about the return value of require changing). Here's the ChangeLog for that change: 2004-08-23 Satyaki Das * mh-acros.el (mh-require-cl): Remove unneeded autoloads. (require): Add an advice to the function so that at compile time the uncompiled file is loaded. This avoids compilation problems when built in the Emacs tree. Satyaki, just out of curiosity, do you remember what the problems were? Would we be able to remove the require defadvice if we removed the circular dependencies? -- Bill Wohler http://www.newt.com/wohler/ GnuPG ID:610BD9AD Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian! If you're passed on the right, you're in the wrong lane. ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click