* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101135: merge the imagemagick branch to trunk
[not found] <E1Om0JS-0000km-Hv@internal.in.savannah.gnu.org>
@ 2010-08-19 12:04 ` Juanma Barranquero
2010-08-19 12:28 ` joakim
0 siblings, 1 reply; 7+ messages in thread
From: Juanma Barranquero @ 2010-08-19 12:04 UTC (permalink / raw)
To: Joakim Verona; +Cc: Emacs developers
A few nitpicks (not related to code, just the merge).
On Thu, Aug 19, 2010 at 09:35, Joakim <joakim@localhost.localdomain> wrote:
> modified:
> ChangeLog
There's just a ChangeLog entry, at top level, but the changes should
be documented in the respective ChangeLogs (src/ChangeLog for src/*
changes, etc.).
> configure
> doc/lispref/display.texi
> etc/NEWS
> lisp/image-mode.el
These aren't mentioned in any ChangeLog.
> +2010-06-12 Joakim Verona <joakim@verona.se>
When merging branches, the date of the ChangeLog is the date the merge
is done, not that of the original changes (that information is
preserved by the branch history).
> + * image.c: Add support for ImageMagick. When HAVE_IMAGEMAGICK is
> + defined:
Usually that information is conveyed by "[HAVE_IMAGEMAGICK]".
> + * config.in, Makefile.in, configure.in
These files do not have a change description in the entry.
Juanma
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101135: merge the imagemagick branch to trunk
2010-08-19 12:04 ` [Emacs-diffs] /srv/bzr/emacs/trunk r101135: merge the imagemagick branch to trunk Juanma Barranquero
@ 2010-08-19 12:28 ` joakim
2010-08-19 14:34 ` Stefan Monnier
0 siblings, 1 reply; 7+ messages in thread
From: joakim @ 2010-08-19 12:28 UTC (permalink / raw)
To: Juanma Barranquero; +Cc: Emacs developers
Juanma Barranquero <lekktu@gmail.com> writes:
> A few nitpicks (not related to code, just the merge).
>
> On Thu, Aug 19, 2010 at 09:35, Joakim <joakim@localhost.localdomain> wrote:
>
>> modified:
>> ChangeLog
>
> There's just a ChangeLog entry, at top level, but the changes should
> be documented in the respective ChangeLogs (src/ChangeLog for src/*
> changes, etc.).
>
>> configure
>> doc/lispref/display.texi
>> etc/NEWS
>> lisp/image-mode.el
>
> These aren't mentioned in any ChangeLog.
>
>> +2010-06-12 Joakim Verona <joakim@verona.se>
>
> When merging branches, the date of the ChangeLog is the date the merge
> is done, not that of the original changes (that information is
> preserved by the branch history).
>
>> + * image.c: Add support for ImageMagick. When HAVE_IMAGEMAGICK is
>> + defined:
>
> Usually that information is conveyed by "[HAVE_IMAGEMAGICK]".
>
>> + * config.in, Makefile.in, configure.in
>
> These files do not have a change description in the entry.
Ok, Ill try to fix these issues.
> Juanma
>
--
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101135: merge the imagemagick branch to trunk
2010-08-19 12:28 ` joakim
@ 2010-08-19 14:34 ` Stefan Monnier
2010-08-20 2:05 ` Katsumi Yamaoka
0 siblings, 1 reply; 7+ messages in thread
From: Stefan Monnier @ 2010-08-19 14:34 UTC (permalink / raw)
To: joakim; +Cc: Juanma Barranquero, Emacs developers
> Ok, Ill try to fix these issues.
While you're at it, try to move the content of README.imagemagick into
some already existing file (maybe etc/TODO).
Stefan
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101135: merge the imagemagick branch to trunk
2010-08-19 14:34 ` Stefan Monnier
@ 2010-08-20 2:05 ` Katsumi Yamaoka
2010-08-20 5:56 ` Katsumi Yamaoka
0 siblings, 1 reply; 7+ messages in thread
From: Katsumi Yamaoka @ 2010-08-20 2:05 UTC (permalink / raw)
To: emacs-devel
bootstrap failed --with-imagemagick on Fedora 13 when dumping temacs.
gcc ... -o temacs ... -lMagickWand -lMagickCore ...
/usr/lib/gcc/i686-redhat-linux/4.4.4/../../../libMagickWand.so:\
undefined reference to `__gcc_personality_v0@GCC_3.3.1'
I've installed these imagick packages today:
ImageMagick.i686 6.5.8.10-6.fc13 @anaconda-InstallationRepo-201005130056.i386
ImageMagick-c++.i686 6.5.8.10-6.fc13 @fedora
ImageMagick-c++-devel.i686 6.5.8.10-6.fc13 @fedora
ImageMagick-debuginfo.i686 6.5.8.10-6.fc13 @fedora-debuginfo
ImageMagick-devel.i686 6.5.8.10-6.fc13 @fedora
ImageMagick-djvu.i686 6.5.8.10-6.fc13 @fedora
ImageMagick-doc.i686 6.5.8.10-6.fc13 @fedora
ImageMagick-perl.i686 6.5.8.10-6.fc13 @fedora
gallery2-imagemagick.noarch 2.3.1-1.fc13 @fedora
Any other info I have to add?
Thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101135: merge the imagemagick branch to trunk
2010-08-20 2:05 ` Katsumi Yamaoka
@ 2010-08-20 5:56 ` Katsumi Yamaoka
2010-08-20 8:58 ` Eli Zaretskii
2010-08-20 10:43 ` joakim
0 siblings, 2 replies; 7+ messages in thread
From: Katsumi Yamaoka @ 2010-08-20 5:56 UTC (permalink / raw)
To: emacs-devel
Katsumi Yamaoka wrote:
> bootstrap failed --with-imagemagick on Fedora 13 when dumping temacs.
> gcc ... -o temacs ... -lMagickWand -lMagickCore ...
> /usr/lib/gcc/i686-redhat-linux/4.4.4/../../../libMagickWand.so:\
> undefined reference to `__gcc_personality_v0@GCC_3.3.1'
I was successful in bootstrapping Emacs after having installed
ImageMagick-6.6.3-7 in /usr/local/ from scratch. Specifying
LDFLAGS to '-L/usr/local/lib -Xlinker -R/usr/local/lib' was needed.
Works fine so far.
My failure in the first try seems to be due to something wrong in
the imagick packages that Fedora provides. Sorry for the noise.
> I've installed these imagick packages today:
> ImageMagick.i686 6.5.8.10-6.fc13 @anaconda-InstallationRepo-201005130056.i386
> ImageMagick-c++.i686 6.5.8.10-6.fc13 @fedora
> ImageMagick-c++-devel.i686 6.5.8.10-6.fc13 @fedora
> ImageMagick-debuginfo.i686 6.5.8.10-6.fc13 @fedora-debuginfo
> ImageMagick-devel.i686 6.5.8.10-6.fc13 @fedora
> ImageMagick-djvu.i686 6.5.8.10-6.fc13 @fedora
> ImageMagick-doc.i686 6.5.8.10-6.fc13 @fedora
> ImageMagick-perl.i686 6.5.8.10-6.fc13 @fedora
> gallery2-imagemagick.noarch 2.3.1-1.fc13 @fedora
> Any other info I have to add?
> Thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101135: merge the imagemagick branch to trunk
2010-08-20 5:56 ` Katsumi Yamaoka
@ 2010-08-20 8:58 ` Eli Zaretskii
2010-08-20 10:43 ` joakim
1 sibling, 0 replies; 7+ messages in thread
From: Eli Zaretskii @ 2010-08-20 8:58 UTC (permalink / raw)
To: Katsumi Yamaoka; +Cc: emacs-devel
> Date: Fri, 20 Aug 2010 14:56:24 +0900
> From: Katsumi Yamaoka <yamaoka@jpl.org>
>
> Katsumi Yamaoka wrote:
> > bootstrap failed --with-imagemagick on Fedora 13 when dumping temacs.
>
> > gcc ... -o temacs ... -lMagickWand -lMagickCore ...
> > /usr/lib/gcc/i686-redhat-linux/4.4.4/../../../libMagickWand.so:\
> > undefined reference to `__gcc_personality_v0@GCC_3.3.1'
>
> I was successful in bootstrapping Emacs after having installed
> ImageMagick-6.6.3-7 in /usr/local/ from scratch. Specifying
> LDFLAGS to '-L/usr/local/lib -Xlinker -R/usr/local/lib' was needed.
> Works fine so far.
>
> My failure in the first try seems to be due to something wrong in
> the imagick packages that Fedora provides. Sorry for the noise.
It's not noise. I think we should have the ImageMagick version
information in README and the problematic versions in etc/PROBLEMS.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101135: merge the imagemagick branch to trunk
2010-08-20 5:56 ` Katsumi Yamaoka
2010-08-20 8:58 ` Eli Zaretskii
@ 2010-08-20 10:43 ` joakim
1 sibling, 0 replies; 7+ messages in thread
From: joakim @ 2010-08-20 10:43 UTC (permalink / raw)
To: Katsumi Yamaoka; +Cc: emacs-devel
Katsumi Yamaoka <yamaoka@jpl.org> writes:
> Katsumi Yamaoka wrote:
>> bootstrap failed --with-imagemagick on Fedora 13 when dumping temacs.
>
>> gcc ... -o temacs ... -lMagickWand -lMagickCore ...
>> /usr/lib/gcc/i686-redhat-linux/4.4.4/../../../libMagickWand.so:\
>> undefined reference to `__gcc_personality_v0@GCC_3.3.1'
>
> I was successful in bootstrapping Emacs after having installed
> ImageMagick-6.6.3-7 in /usr/local/ from scratch. Specifying
> LDFLAGS to '-L/usr/local/lib -Xlinker -R/usr/local/lib' was needed.
> Works fine so far.
>
> My failure in the first try seems to be due to something wrong in
> the imagick packages that Fedora provides. Sorry for the noise.
>
>> I've installed these imagick packages today:
>
>> ImageMagick.i686 6.5.8.10-6.fc13 @anaconda-InstallationRepo-201005130056.i386
>> ImageMagick-c++.i686 6.5.8.10-6.fc13 @fedora
>> ImageMagick-c++-devel.i686 6.5.8.10-6.fc13 @fedora
>> ImageMagick-debuginfo.i686 6.5.8.10-6.fc13 @fedora-debuginfo
>> ImageMagick-devel.i686 6.5.8.10-6.fc13 @fedora
>> ImageMagick-djvu.i686 6.5.8.10-6.fc13 @fedora
>> ImageMagick-doc.i686 6.5.8.10-6.fc13 @fedora
>> ImageMagick-perl.i686 6.5.8.10-6.fc13 @fedora
>> gallery2-imagemagick.noarch 2.3.1-1.fc13 @fedora
>
>> Any other info I have to add?
This is odd. I developed the patch on Fedora 12 and 13. I tried a clean
build just now with the same versions you seem to have, withouth
problems.
>> Thanks.
--
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-08-20 10:43 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1Om0JS-0000km-Hv@internal.in.savannah.gnu.org>
2010-08-19 12:04 ` [Emacs-diffs] /srv/bzr/emacs/trunk r101135: merge the imagemagick branch to trunk Juanma Barranquero
2010-08-19 12:28 ` joakim
2010-08-19 14:34 ` Stefan Monnier
2010-08-20 2:05 ` Katsumi Yamaoka
2010-08-20 5:56 ` Katsumi Yamaoka
2010-08-20 8:58 ` Eli Zaretskii
2010-08-20 10:43 ` joakim
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).