From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: [RFC] avoid gc_in_progress in redisplay
Date: Fri, 19 Oct 2012 12:19:04 +0200 [thread overview]
Message-ID: <8362662293.fsf@gnu.org> (raw)
In-Reply-To: <5080E4C1.7000703@yandex.ru>
> Date: Fri, 19 Oct 2012 09:27:29 +0400
> From: Dmitry Antipov <dmantipov@yandex.ru>
>
> IIUC if we call to unblock_input _after_ clearing gc_in_progress in Fgarbage_collect,
> we can avoid gc_in_progress == true cases in redisplay routines; thus, some things
> may be simplified. Comments?
I think this is a red herring: mouse event cannot possibly come in
while GC is in progress, since we have switched to SYNC_INPUT. Any
mouse event that is detected during GC will just set a flag, which
will be handled either as part of QUIT or when Emacs becomes idle.
And I don't believe GC can QUIT, can it?
Like I wrote when we switched all platforms to SYNC_INPUT: there's lot
of code all over the place that still tries to cater to asynchronous
input events (mouse highlight being one of them) that can no longer
happen. We need to remove that code and delete the corresponding data
structure members which support that code.
But I wouldn't recommend doing that during the feature freeze.
prev parent reply other threads:[~2012-10-19 10:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 5:27 [RFC] avoid gc_in_progress in redisplay Dmitry Antipov
2012-10-19 10:19 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8362662293.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dmantipov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).