From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [RFC] inline DEFUNs Date: Wed, 04 Dec 2013 18:19:50 +0200 Message-ID: <8361r44mhl.fsf@gnu.org> References: <529EF98F.6050903@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1386174003 32288 80.91.229.3 (4 Dec 2013 16:20:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 Dec 2013 16:20:03 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Antipov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 04 17:20:08 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VoFBH-0001Mi-PG for ged-emacs-devel@m.gmane.org; Wed, 04 Dec 2013 17:20:07 +0100 Original-Received: from localhost ([::1]:49171 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoFBH-0005XF-Bv for ged-emacs-devel@m.gmane.org; Wed, 04 Dec 2013 11:20:07 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56085) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoFB9-0005Pr-Ic for emacs-devel@gnu.org; Wed, 04 Dec 2013 11:20:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VoFB4-0003vA-1E for emacs-devel@gnu.org; Wed, 04 Dec 2013 11:19:59 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:63634) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoFB3-0003v1-P3 for emacs-devel@gnu.org; Wed, 04 Dec 2013 11:19:53 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MXA00J00HJVG800@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Wed, 04 Dec 2013 18:19:51 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MXA00JMQIP3K510@a-mtaout20.012.net.il>; Wed, 04 Dec 2013 18:19:51 +0200 (IST) In-reply-to: <529EF98F.6050903@yandex.ru> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:166083 Archived-At: > Date: Wed, 04 Dec 2013 13:44:47 +0400 > From: Dmitry Antipov > > Recent discussion about dropping selected_window (started at > http://lists.gnu.org/archive/html/emacs-devel/2013-11/msg01090.html) > raises an interesting question. In short, we want Fselected_window > fast (read: inline in C) but still accessible from Lisp. > > Possible solution is to split DEFSUBR from DEFUN and use DEFINLINE in > .h to define inline function, with matching DEFSUBR somewhere in .c. > Attached patch converts Fcurrent_buffer to inline function. On my > system, this effectively eliminates 63 calls to Fcurrent_buffer at the > cost of increasing .text with just 48 bytes (for default '-O2 -g3' build). > This feature also requires special support in make-docfile and Lisp code > responsible to find and jump to a function definition. Perhaps I don't understand some subtlety here, but the usual way of dealing with this is to have an inline C function, which can then be called from C, and have Fcurrent_buffer that calls that inline function. Am I missing something?