From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Removing rollback from VC mode - request for comment Date: Mon, 15 Dec 2014 19:21:19 +0200 Message-ID: <8361dcygkw.fsf@gnu.org> References: <20141211092138.6D5F6C008E@snark.thyrsus.com> <20141211123629.GA25499@thyrsus.com> <83fvcmtax5.fsf@gnu.org> <87wq5y9l4e.fsf@wanadoo.es> <83wq5yrr77.fsf@gnu.org> <83r3w5sy1g.fsf@gnu.org> <87bnn8hn62.fsf@yahoo.fr> <83sigkr7u5.fsf@gnu.org> <87iohe4eo7.fsf@bernoul.li> <83h9wyxbxt.fsf@gnu.org> <87h9wx83f1.fsf@bernoul.li> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1418664137 31536 80.91.229.3 (15 Dec 2014 17:22:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 15 Dec 2014 17:22:17 +0000 (UTC) Cc: theonewiththeevillook@yahoo.fr, emacs-devel@gnu.org, john.b.mastro@gmail.com To: Jonas Bernoulli Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 15 18:22:10 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Y0ZLV-0002y2-TK for ged-emacs-devel@m.gmane.org; Mon, 15 Dec 2014 18:22:10 +0100 Original-Received: from localhost ([::1]:41082 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0ZLV-0000O4-AV for ged-emacs-devel@m.gmane.org; Mon, 15 Dec 2014 12:22:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0ZL1-0000HQ-CA for emacs-devel@gnu.org; Mon, 15 Dec 2014 12:21:45 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0ZKw-00050t-KL for emacs-devel@gnu.org; Mon, 15 Dec 2014 12:21:39 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:58825) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0ZKw-00050P-Bk for emacs-devel@gnu.org; Mon, 15 Dec 2014 12:21:34 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NGM00A00VYSDK00@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Mon, 15 Dec 2014 19:21:32 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NGM009DGW7WZH80@a-mtaout22.012.net.il>; Mon, 15 Dec 2014 19:21:32 +0200 (IST) In-reply-to: <87h9wx83f1.fsf@bernoul.li> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:180162 Archived-At: > From: Jonas Bernoulli > Cc: theonewiththeevillook@yahoo.fr, john.b.mastro@gmail.com, emacs-devel@gnu.org > Date: Mon, 15 Dec 2014 14:10:10 +0100 > > Magit uses a lot of overlays indeed, but that is slowly being phased out > where possible. That's very good news, thanks. > One thing that will certainly stay is that section bodies are made > invisible using the invisible text-property. Invisible text is not too bad in itself, but beware of hiding too much of it: it causes user dissatisfaction when redisplay seems to become sluggish (because what the user sees as a small amount of text is actually a very large chunk, and the display engine needs to traverse it when it makes layout decisions). > I cannot think of another place were Magit hides text. You mention > newlines being molested, but I cannot remember having seen anything > like that in Magit. Maybe it was in the past. Or maybe I just misremembered. > Back to overlays. Magit highlights the current section(s) using an > overlay, which by default changes the background color like the region > does. Overlays that change colors or other visual attributes of buffer text don't bother me. I was talking about overlay strings and display properties that are strings. > > Instead of overlaying buffer text with display and overlay strings, it > > could simply format the buffer text any way it likes, and then avoid > > the need to do all that. > > If a user wants to highlight the current section and also refnames with > a background color, which don't get lost, then Magit *does* have to use > overlays. Again, this use of overlays isn't a problem from my POV. I meant only displaying text that isn't actually in the buffer, by using overlay and display strings. Thanks.