From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Help with contributing first change (patch for debbugs 354) Date: Fri, 27 Feb 2015 09:35:43 +0200 Message-ID: <8361an6c34.fsf@gnu.org> References: <87d24w1akg.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1425022569 3162 80.91.229.3 (27 Feb 2015 07:36:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 27 Feb 2015 07:36:09 +0000 (UTC) Cc: emacs-devel@gnu.org To: Jeff Clough Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 27 08:35:56 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YRFSm-0006R8-63 for ged-emacs-devel@m.gmane.org; Fri, 27 Feb 2015 08:35:56 +0100 Original-Received: from localhost ([::1]:34361 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRFSl-0000hA-GU for ged-emacs-devel@m.gmane.org; Fri, 27 Feb 2015 02:35:55 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46086) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRFSN-0000ek-A0 for emacs-devel@gnu.org; Fri, 27 Feb 2015 02:35:32 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRFSJ-0003J3-I6 for emacs-devel@gnu.org; Fri, 27 Feb 2015 02:35:31 -0500 Original-Received: from mtaout28.012.net.il ([80.179.55.184]:51749) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRFSJ-0003IJ-B0 for emacs-devel@gnu.org; Fri, 27 Feb 2015 02:35:27 -0500 Original-Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NKF001005YSIM00@mtaout28.012.net.il> for emacs-devel@gnu.org; Fri, 27 Feb 2015 09:33:54 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKF00OSF6CIY820@mtaout28.012.net.il>; Fri, 27 Feb 2015 09:33:54 +0200 (IST) In-reply-to: <87d24w1akg.fsf@gmail.com> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.184 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183526 Archived-At: > From: Jeff Clough > Date: Thu, 26 Feb 2015 19:07:27 -0500 > > TL;DR: I am attempting to contribute my first change to GNU Emacs and am > looking for a little hand-holding concerning the tools to use, and > someone to review my change. Thank you. > 1. git checkout master > 2. git pull > 3. git checkout -b wishlist-354 (is this overkill for a small change?) It's up to you. I make such one-off changes directly in master, but then I push them immediately after testing, while you will have to wait until your patch is reviewed and approved. > 4. Changed write-region in "fileio.c" > 5. Tested my change (is building in place advised?) Nothing wrong with building in place. But please do make a point of running the test suite, before and after the change, to make sure there are no regressions. Bonus points for adding tests to test this new feature. > So, what's next? File a bug report with this patch, and wait for a review. Thanks again.