From: Eli Zaretskii <eliz@gnu.org>
To: Jeff Clough <kb1vqh@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Help with contributing first change (patch for debbugs 354)
Date: Fri, 27 Feb 2015 09:35:43 +0200 [thread overview]
Message-ID: <8361an6c34.fsf@gnu.org> (raw)
In-Reply-To: <87d24w1akg.fsf@gmail.com>
> From: Jeff Clough <kb1vqh@gmail.com>
> Date: Thu, 26 Feb 2015 19:07:27 -0500
>
> TL;DR: I am attempting to contribute my first change to GNU Emacs and am
> looking for a little hand-holding concerning the tools to use, and
> someone to review my change.
Thank you.
> 1. git checkout master
> 2. git pull
> 3. git checkout -b wishlist-354 (is this overkill for a small change?)
It's up to you. I make such one-off changes directly in master, but
then I push them immediately after testing, while you will have to
wait until your patch is reviewed and approved.
> 4. Changed write-region in "fileio.c"
> 5. Tested my change (is building in place advised?)
Nothing wrong with building in place. But please do make a point of
running the test suite, before and after the change, to make sure
there are no regressions. Bonus points for adding tests to test this
new feature.
> So, what's next?
File a bug report with this patch, and wait for a review.
Thanks again.
prev parent reply other threads:[~2015-02-27 7:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 0:07 Help with contributing first change (patch for debbugs 354) Jeff Clough
2015-02-27 7:20 ` Paul Eggert
2015-02-27 7:35 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8361an6c34.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=kb1vqh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).