From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Ensuring commit messages with correct copyright info Date: Tue, 08 Mar 2016 21:22:39 +0200 Message-ID: <8360wwrczk.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1457465002 2462 80.91.229.3 (8 Mar 2016 19:23:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 8 Mar 2016 19:23:22 +0000 (UTC) Cc: emacs-devel@gnu.org To: Lars Magne Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 08 20:23:04 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1adNDf-0008NG-TD for ged-emacs-devel@m.gmane.org; Tue, 08 Mar 2016 20:23:00 +0100 Original-Received: from localhost ([::1]:36815 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adNDf-0005ZW-DG for ged-emacs-devel@m.gmane.org; Tue, 08 Mar 2016 14:22:59 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41482) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adNDJ-0005PR-Cy for emacs-devel@gnu.org; Tue, 08 Mar 2016 14:22:41 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adNDE-0000wO-DP for emacs-devel@gnu.org; Tue, 08 Mar 2016 14:22:37 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46062) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adNDE-0000wK-Au; Tue, 08 Mar 2016 14:22:32 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3078 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1adNDC-00076i-RC; Tue, 08 Mar 2016 14:22:31 -0500 In-reply-to: (message from Lars Magne Ingebrigtsen on Tue, 08 Mar 2016 19:47:29 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:201195 Archived-At: > From: Lars Magne Ingebrigtsen > Date: Tue, 08 Mar 2016 19:47:29 +0100 > > The thing that comes up, again and again, as the main reason we should > be able to edit commit messages (and therefore we should have > ChangeLogs, because we can edit those) is that we (er, mainly me :-)) > sometimes forget to put > > Copyright-paperwork-exempt: yes > > into the commit messages. It's one problem, but it's not the only one. Just look at the generated ChangeLog file, and you will see the blunders. We need to educate contributors to do a better job, and I see no way of doing that without some means of fixing the mistakes. > So why not concentrate of fixing that particular problem? I think > something that might help is that if the committer is different from the > author, then there should always be something in the commit message that > explicitly says what the copyright status of the work is. > > That is, unless the line > > Copyright-paperwork-exempt: yes > > or the line > > Copyright-assigned: yes > > is present in the commit message, then the commit... hooks? (the thing > that refuses to check in files with trailing newlines etc; I don't know > the details about how that works) should refuse the commit. > > Then it should be pretty impossible to forget this stuff, and there's > one less reason to want to edit the commit messages. So you are suggesting that instead of doing TRT in perhaps 2% of commit messages, we should now add a completely redundant text in 98% of them? How does this make sense? > (Note: This hook should only be run if there's an Author: header in the > vc log buffer. Everybody who has commit rights have already assigned > copyright, so it's unnecessary to add those if the committer and the > author are the same person.) I already use --author in those cases, why should I do anything else?