unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: acm@muc.de, larsi@gnus.org, emacs-devel@gnu.org
Subject: Re: Checking in files with trailing white space
Date: Tue, 13 Dec 2016 21:00:16 +0200	[thread overview]
Message-ID: <8360mnbqnz.fsf@gnu.org> (raw)
In-Reply-To: <d93db70d-d6c6-f41d-3606-bcd95c1cd772@cs.ucla.edu> (message from Paul Eggert on Tue, 13 Dec 2016 10:33:07 -0800)

> Cc: acm@muc.de, larsi@gnus.org, emacs-devel@gnu.org
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Tue, 13 Dec 2016 10:33:07 -0800
> 
> > what about data files that cannot be easily produced from text on
> > any garden-variety system?
> 
> An Elisp program can easily produce data files in any format, so this 
> should not be a problem in practice.

Producing arbitrary output from a text description might not be easy.
Unless you are willing to accept ASCII-ized binary files in the form
of hex dump or something.  That might make some files harder to read,
not easier, though.  IOW, Git will be happier, but we the humans might
not be.

> > We don't want to make the job of adding tests any harder than it 
> > already is. 
> 
> We can tolerate low-quality tests, I suppose. But it's better if tests 
> are readable and work well with standard tools like "git diff". So we 
> should encourage replacing binary data with text in the repository, as 
> this will make the tests more maintainable.

I'm okay with encouraging that, I just don't think we should require
it.

> This is not merely a practical point; it's also a philosophical one. The 
> GPL distinguishes source code from object code. Typically, binary data 
> files are "object code" in the GPL sense, in that they are not the 
> preferred form of a test case for software-development tools like Git. 
> Whenever we distribute object code, the GPL implies that we should also 
> distribute the corresponding source code that is easy for Git etc. to 
> work with. This source code belongs in the Git repository, and the 
> corresponding object code need not and should not be in the Git repository.

I'm not sure this is relevant here.  E.g., we distribute Emacs sources
as a compressed archive, not as a set of plain-text files.  So stuff
like entry.strange.gz is not an issue in this respect, I think.



  reply	other threads:[~2016-12-13 19:00 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-20 12:55 Checking in files with trailing white space Lars Magne Ingebrigtsen
2016-03-20 13:08 ` Lars Magne Ingebrigtsen
2016-12-11 13:31   ` Alan Mackenzie
2016-12-11 18:50     ` Lars Ingebrigtsen
2016-12-12 22:16       ` Alan Mackenzie
2016-12-12 22:57         ` Paul Eggert
2016-12-13  3:32           ` Eli Zaretskii
2016-12-13  7:31             ` Paul Eggert
2016-12-13 16:01               ` Eli Zaretskii
2016-12-13 18:33                 ` Paul Eggert
2016-12-13 19:00                   ` Eli Zaretskii [this message]
2016-12-13 22:39                     ` Paul Eggert
2016-12-14  3:31                       ` Eli Zaretskii
2016-12-14  7:47                         ` Paul Eggert
2016-12-14 15:32                           ` Eli Zaretskii
2016-12-14 18:15                             ` Paul Eggert
2016-12-14 19:26                               ` Eli Zaretskii
2016-12-13 18:28           ` Alan Mackenzie
2016-12-13 18:39             ` Paul Eggert
2016-03-21 13:10 ` Stefan Monnier
2016-03-21 13:59   ` Lars Magne Ingebrigtsen
2016-03-21 18:09     ` Paul Eggert
2016-04-04 20:05       ` Lars Magne Ingebrigtsen
2016-04-04 21:55         ` Paul Eggert
2016-04-24 13:13           ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8360mnbqnz.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=acm@muc.de \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).