From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Refactor digest authentication in url-auth Date: Sat, 11 Mar 2017 12:08:50 +0200 Message-ID: <8360jgdt1p.fsf@gnu.org> References: <1487106777-17025-1-git-send-email-jarno@malmari.fi> <834lzrrbwu.fsf@gnu.org> <837f4esla4.fsf@gnu.org> <87r32bhg86.fsf@vabi> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1489227054 12342 195.159.176.226 (11 Mar 2017 10:10:54 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 11 Mar 2017 10:10:54 +0000 (UTC) Cc: emacs-devel@gnu.org To: Jarno Malmari Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 11 11:10:48 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmdz0-0002C4-3a for ged-emacs-devel@m.gmane.org; Sat, 11 Mar 2017 11:10:42 +0100 Original-Received: from localhost ([::1]:42673 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cmdz6-0008RO-5Z for ged-emacs-devel@m.gmane.org; Sat, 11 Mar 2017 05:10:48 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cmdxX-0007hY-GC for emacs-devel@gnu.org; Sat, 11 Mar 2017 05:09:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cmdxU-0002bq-A1 for emacs-devel@gnu.org; Sat, 11 Mar 2017 05:09:11 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41626) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cmdxU-0002bl-6K; Sat, 11 Mar 2017 05:09:08 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4827 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cmdxT-0007iO-Hl; Sat, 11 Mar 2017 05:09:07 -0500 In-reply-to: <87r32bhg86.fsf@vabi> (message from Jarno Malmari on Sun, 05 Mar 2017 17:54:01 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:212898 Archived-At: > From: Jarno Malmari > Cc: > Date: Sun, 05 Mar 2017 17:54:01 +0200 > > For what it's worth I'd consider the refactoring patch (PATCH 1/2) quite > safe to merge in and would suggest prioritizing reviewing efforts on the > latter patch (PATCH 2/2) that contains the actual QOP feature. Since no one seems to be interested to review this patch, I did that myself. I have two comments: > +(defun url-digest-auth-build-response (key url realm attrs) > + "Compute authorization string for the given challenge using KEY. > + > +The strings looks like 'Digest username=\"John\", realm=\"The > +Realm\", ...' Typo: should be "look", not "looks". > +(defun url-digest-find-new-key (url realm prompt) > + "Find new key either from auth-source or interactively. > +The key is looked for based on URL and REALM. If PROMPT is > +non-nil, ask interactively in case credentials weren't found from > +auth-source." This function's doc string looks strikingly different from the rest of the functions you wrote: not as detailed and clear as the rest. Can you rework it to be more in line with the rest of the functions? With those minor issues fixed, I will push your changes. Thanks.