From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: rename STRING_SET_CHARS to STRING_SET_SIZE Date: Mon, 17 Apr 2017 19:24:28 +0300 Message-ID: <8360i3dmtf.fsf@gnu.org> References: <83a89gq3us.fsf@gnu.org> <87bmtjiv0w.fsf_-_@lifelogs.com> <83o9xjn06c.fsf@gnu.org> <87shmeb5ln.fsf_-_@lifelogs.com> <83y3w5z1ez.fsf@gnu.org> <87lgr6yakj.fsf@lifelogs.com> <87wpamww9k.fsf@lifelogs.com> <8337daggnj.fsf@gnu.org> <87d1cdwxt6.fsf@lifelogs.com> <83tw5pg1q3.fsf@gnu.org> <87zifhulc2.fsf@lifelogs.com> <87vaq3uipz.fsf_-_@lifelogs.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1492446244 24819 195.159.176.226 (17 Apr 2017 16:24:04 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 17 Apr 2017 16:24:04 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 17 18:24:01 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d09RZ-0006Mx-6i for ged-emacs-devel@m.gmane.org; Mon, 17 Apr 2017 18:24:01 +0200 Original-Received: from localhost ([::1]:37724 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d09Rf-00045C-4l for ged-emacs-devel@m.gmane.org; Mon, 17 Apr 2017 12:24:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51150) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d09RW-00043q-4S for emacs-devel@gnu.org; Mon, 17 Apr 2017 12:23:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d09RT-0003Iv-1n for emacs-devel@gnu.org; Mon, 17 Apr 2017 12:23:58 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47643) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d09RS-0003Ir-V6 for emacs-devel@gnu.org; Mon, 17 Apr 2017 12:23:54 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1766 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d09RS-0004aK-74 for emacs-devel@gnu.org; Mon, 17 Apr 2017 12:23:54 -0400 In-reply-to: <87vaq3uipz.fsf_-_@lifelogs.com> (message from Ted Zlatanov on Mon, 17 Apr 2017 12:00:56 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214072 Archived-At: > From: Ted Zlatanov > Date: Mon, 17 Apr 2017 12:00:56 -0400 > > Eli, anyone else, is it OK to do that renaming of STRING_SET_CHARS to > STRING_SET_SIZE? It is called STRING_SET_CHARS because it sets the same member that SCHARS returns. And CHARS is actually correct, because the 'size' member counts string characters (as opposed to bytes). So I don't think there's a problem with the name here, you just need ti get used to thinking about it as 'chars', not 'size'.