From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] Integrate module test with normal test suite
Date: Sat, 22 Apr 2017 17:47:55 +0300
Message-ID: <8360hwqz1g.fsf@gnu.org>
References: <20170422142327.12213-1-phst@google.com>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: blaine.gmane.org
X-Trace: blaine.gmane.org 1492872442 16783 195.159.176.226 (22 Apr 2017 14:47:22 GMT)
X-Complaints-To: usenet@blaine.gmane.org
NNTP-Posting-Date: Sat, 22 Apr 2017 14:47:22 +0000 (UTC)
Cc: phst@google.com, emacs-devel@gnu.org
To: Philipp Stephani <p.stephani2@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 22 16:47:18 2017
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by blaine.gmane.org with esmtp (Exim 4.84_2)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1d1wJi-0004GG-0C
	for ged-emacs-devel@m.gmane.org; Sat, 22 Apr 2017 16:47:18 +0200
Original-Received: from localhost ([::1]:35867 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1d1wJn-0001FL-Tf
	for ged-emacs-devel@m.gmane.org; Sat, 22 Apr 2017 10:47:23 -0400
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57452)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1d1wJf-0001EY-DQ
	for emacs-devel@gnu.org; Sat, 22 Apr 2017 10:47:17 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1d1wJe-0003xV-M7
	for emacs-devel@gnu.org; Sat, 22 Apr 2017 10:47:15 -0400
Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51131)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1d1wJa-0003wK-RB; Sat, 22 Apr 2017 10:47:10 -0400
Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3956
	helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1d1wJa-0001x4-27; Sat, 22 Apr 2017 10:47:10 -0400
In-reply-to: <20170422142327.12213-1-phst@google.com> (message from Philipp
	Stephani on Sat, 22 Apr 2017 16:23:27 +0200)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:214212
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/214212>

> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Sat, 22 Apr 2017 16:23:27 +0200
> Cc: Philipp Stephani <phst@google.com>
> 
> +$(test_module): $(srcdir)/../src/emacs-module.[ch]
> +	$(MAKE) -C $(test_module_dir) $(test_module_name) \
> +	  SO=$(patsubst .%,%,@MODULES_SUFFIX@)

Can we get rid of the patsubst thing, please?  It makes little sense
to assume in the Makefile that SO doesn't include the leading period,
only to have to delete it from the value computed by configure.

Also, I believe you need to quote the string after SO=, as it includes
whitespace.

Thanks.