From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-26 0feb673: Display raw bytes as belonging to 'eight-bit' charset Date: Fri, 27 Jul 2018 16:53:21 +0300 Message-ID: <836010ss32.fsf@gnu.org> References: <20180727064907.6305.13029@vcs0.savannah.gnu.org> <20180727064909.85288203C0@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1532699530 984 195.159.176.226 (27 Jul 2018 13:52:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 27 Jul 2018 13:52:10 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier , Kenichi Handa Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 27 15:52:06 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fj3A5-000098-DP for ged-emacs-devel@m.gmane.org; Fri, 27 Jul 2018 15:52:05 +0200 Original-Received: from localhost ([::1]:41426 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fj3CC-0004Oz-67 for ged-emacs-devel@m.gmane.org; Fri, 27 Jul 2018 09:54:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fj3BO-0004Ot-BW for emacs-devel@gnu.org; Fri, 27 Jul 2018 09:53:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fj3BN-00069R-Kr for emacs-devel@gnu.org; Fri, 27 Jul 2018 09:53:26 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59918) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fj3BJ-00065F-28; Fri, 27 Jul 2018 09:53:21 -0400 Original-Received: from [176.228.60.248] (port=4125 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fj3BI-0004k1-Gq; Fri, 27 Jul 2018 09:53:20 -0400 In-reply-to: (message from Stefan Monnier on Fri, 27 Jul 2018 08:38:56 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227858 Archived-At: > From: Stefan Monnier > Date: Fri, 27 Jul 2018 08:38:56 -0400 > Cc: Eli Zaretskii > > > (char-charset char)))) > > + ;; TIS620.2533 overlaps eight-bit-control, but we want to > > + ;; show eight-bit for raw bytes, not some obscure character > > + ;; set no one heard of. > > + (charset (if (eq charset 'tis620-2533) > > + 'eight-bit > > + charset)) > > Do we need `char-charset` to return `tis620-2533` for these, or could we > instead of the above change `char-charset` to return `eight-bit` or > `eight-bit-control`? I don't know, because I don't understand why in this situation we return tis620-2533 instead of eight-bit. Maybe it's intended, and maybe it's just a side effect of how we implement char-charset. The above change is safe, more-or-less, because it only affects how we display information about characters. Making an equivalent change inside char-charset would affect all users of that API.