From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: tabulated-list sort icon is reversed Date: Sat, 09 Mar 2019 17:06:11 +0200 Message-ID: <835zss84v0.fsf@gnu.org> References: <87d0v1lsns.fsf@fastmail.fm> <532F6D74-E21C-45A2-B85B-01133DE1E8A1@scratch.space> <6e662c5b-3d04-2157-6712-aadcb6077f2b@gmail.com> <83a7j0pzbh.fsf@gnu.org> <83sgwpm92r.fsf@gnu.org> <83imx1h4rm.fsf@gnu.org> <83tvglf8h0.fsf@gnu.org> <83r2bhaegh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="22611"; mail-complaints-to="usenet@blaine.gmane.org" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Philippe Vaucher Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 09 16:06:34 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h2dYX-0005kp-PP for ged-emacs-devel@m.gmane.org; Sat, 09 Mar 2019 16:06:33 +0100 Original-Received: from localhost ([127.0.0.1]:60102 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2dYW-00061u-Om for ged-emacs-devel@m.gmane.org; Sat, 09 Mar 2019 10:06:32 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55233) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2dYR-00061l-Ew for emacs-devel@gnu.org; Sat, 09 Mar 2019 10:06:28 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59420) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2dYQ-00086W-Nq; Sat, 09 Mar 2019 10:06:26 -0500 Original-Received: from [176.228.60.248] (port=1384 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h2dYP-0008Qb-Sn; Sat, 09 Mar 2019 10:06:26 -0500 In-reply-to: (message from Philippe Vaucher on Sat, 9 Mar 2019 11:18:31 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233971 Archived-At: > From: Philippe Vaucher > Date: Sat, 9 Mar 2019 11:18:31 +0100 > Cc: Stefan Monnier , Emacs developers > > Thanks for the feekback. Here is a patch with all your suggested modifications. Thanks. We are almost there. > About the manual, given it's the first time I edit it I went for a very minimalist approach, please tell me if I should > mention the default values, or the type of the defcustom in there. What is needed is a bit more descriptive text about these options. You could write that text only once, for the first option, and in the others say something like Like @code{tabulated-list-gui-sort-indicator-asc}, but used when ... > +(defcustom tabulated-list-gui-sort-indicator-asc ?▼ > + "Indicator for column sorted in ascending order, for GUI frames. See > + `tabulated-list-tty-sort-indicator-asc' for indicator used on > + text-mode frames." The first line of the doc string should be a single complete sentence. > -(defvar tabulated-list-glyphless-char-display > +(defun tabulated-list-make-glyphless-char-display-table () > + "Make the `glyphless-char-display' table used in Tabulated List Likewise here. > +buffers for text-mode frames. This table is used for displaying the ^^ Two spaces between sentences, please.