Re: [Emacs-diffs] master d68ed15: Implement and document XDG-style startup files under ~/.config.

[Eli Zaretskii <eliz@gnu.org>]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Sun, 26 May 2019 18:40:10 -0400
> Cc: "Eric S. Raymond" <esr@thyrsus.com>
> 
> > -;;; startup.el --- process Emacs shell arguments  -*- lexical-binding: t -*-
> > +;; startup.el --- process Emacs shell arguments  -*- lexical-binding: t -*-
> 
> This is an error, it should be 3 semi-colons.
> 
> > +(defun find-init-path (fn)
> > +  "Look in ~/.config/FOO or ~/.FOO for the dotfile or dot directory FOO.
> > +It is expected that the output will undergo ~ expansion.  Implements the
> > +XDG convention for dotfiles."
> > +  (let* ((xdg-path (concat "~" init-file-user "/.config/" fn))
> > +        (oldstyle-path (concat "~" init-file-user "/." fn))
> > +        (found-path (if (file-exists-p xdg-path) xdg-path oldstyle-path)))
> > +    found-path))
> 
> AFAICT this is only used during startup and hence shouldn't have such
> an "official sounding" name.  It could/should use a "startup--" prefix,
> for example.
> 
> Furthermore it shouldn't say "path" but "filename" to follow our
> naming convention.

No response in a week.

Would someone like to suggest changes to fix the problems in this
commit?  If so, please show the proposed changes, and let's discuss
them.  Failing that, I will revert that commit in a couple of days.