unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: kbrown@cornell.edu, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 0528a7c: Ensure that expand-file-name returns an absolute file name
Date: Tue, 09 Jul 2019 19:07:01 +0300	[thread overview]
Message-ID: <835zob5h0a.fsf@gnu.org> (raw)
In-Reply-To: <jwva7dn6xoh.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Tue, 09 Jul 2019 11:25:50 -0400)

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: kbrown@cornell.edu,  emacs-devel@gnu.org
> Date: Tue, 09 Jul 2019 11:25:50 -0400
> 
> > It isn't entirely arbitrary.
> 
> I'd have gone with "/", but I also consider that as arbitrary: I don't
> think there can be a non-arbitrary choice here, other than signaling
> an error because we don't have any information that can give us a hint
> about what was the intended absolute directory.

I see nothing wrong with a somewhat arbitrary interpretation of such a
default-directory value.

> > I think expand-file-name should try to avoid signaling an error as
> > much as possible, because it is called by many primitives and core
> > functions.  If we signal an error, we risk getting the users into a
> > situation where they cannot even shut down Emacs, let alone do
> > something less trivial.
> 
> A relative default-directory is something extremely rare, so if some
> operations like C-x C-c fail in that case I wouldn't mind.

I agree that it is rare, but trapping the user even rarely is
something I'd like to avoid as much as reasonably possible.



  reply	other threads:[~2019-07-09 16:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190708223951.10291.7621@vcs0.savannah.gnu.org>
     [not found] ` <20190708223953.3172920BD5@vcs0.savannah.gnu.org>
2019-07-08 23:13   ` [Emacs-diffs] master 0528a7c: Ensure that expand-file-name returns an absolute file name Stefan Monnier
2019-07-09  2:35     ` Eli Zaretskii
2019-07-09  2:40       ` Daniel Sutton
2019-07-09  3:46       ` Stefan Monnier
2019-07-09 11:56         ` Ken Brown
2019-07-09 14:50         ` Eli Zaretskii
2019-07-09 15:25           ` Stefan Monnier
2019-07-09 16:07             ` Eli Zaretskii [this message]
2019-07-09 22:34     ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=835zob5h0a.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=kbrown@cornell.edu \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).