From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Question about display engine Date: Wed, 09 Oct 2019 12:02:41 +0300 Message-ID: <835zkywatq.fsf@gnu.org> References: <83ftkxy3r7.fsf@gnu.org> <20190915214233.xkjtoxyfxkyrd2id@Ergus> <20190917021725.xxhhhxcz3nr6sb7z@Ergus> <83blvjw8x9.fsf@gnu.org> <83v9tmqcv7.fsf@gnu.org> <20190921215551.ruu6ji6sjpxydpng@Ergus> <20190926163204.gdb4gxbjtdbysk3y@Ergus> <83zhiohfnx.fsf@gnu.org> <20190929103034.jw5qolfjtbjkbk5p@Ergus> <83impbfjzh.fsf@gnu.org> <20191007154054.zfbsuktkaue5ymbr@Ergus> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="37183"; mail-complaints-to="usenet@blaine.gmane.org" Cc: rudalics@gmx.at, emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 09 19:21:51 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIFep-0009ZX-C7 for ged-emacs-devel@m.gmane.org; Wed, 09 Oct 2019 19:21:51 +0200 Original-Received: from localhost ([::1]:52984 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIFen-00035T-Q0 for ged-emacs-devel@m.gmane.org; Wed, 09 Oct 2019 13:21:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49319) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iI7s5-0001u5-HD for emacs-devel@gnu.org; Wed, 09 Oct 2019 05:03:02 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37778) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iI7s4-0000tN-S6; Wed, 09 Oct 2019 05:03:00 -0400 Original-Received: from [176.228.60.248] (port=3973 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iI7s3-0004OZ-Us; Wed, 09 Oct 2019 05:03:00 -0400 In-reply-to: <20191007154054.zfbsuktkaue5ymbr@Ergus> (message from Ergus on Mon, 7 Oct 2019 17:40:55 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240769 Archived-At: > Date: Mon, 7 Oct 2019 17:40:55 +0200 > From: Ergus > Cc: rudalics@gmx.at, emacs-devel@gnu.org > > I made some of the fixes you suggested in the last email about this > topic. Thanks, see a couple of comments below. > The reduction of the underline-p + underline-stile into a single > underline variable in the struct for me still seems like a good change > for readability and simplification in all the code. Any way in the > future I will try to avoid this kind of modifications even when they > seems to be an improvement... but could you let it pass this time? I don't understand what makes this time special, but OK. > The other changes that seemed to be stylistic too, were actually in > portions of code I wrote for dfci and It was there because I copied some > of it from the previous if-else section... but I can correct it now > right?... so no problem? > > If this is fine may I merge in master? It's OK to merge, after fixing the following nits: > ++++ > +** There is a new face attribute :extend to use the face attributes to > +extend after the end of the line until the end of the window. Such > +:extend is set to nil by default in all faces except for `hl-line` and > +`region` because those extend until the end of the window by default. Please quote 'like this' in NEWS, not `like this`. Also, this NEWS entry should have a header line: ** New face attribute ':extend' to control face extension at EOL. > + /* The stretch width needs to considet the latter ^^^^^^^^ A typo. > /* Display fill-column indicator if needed. */ > - int indicator_column = fill_column_indicator_column (it); > - if (indicator_column >= 0 > - && INT_ADD_WRAPV (it->lnum_pixel_width, indicator_column, > - &indicator_column)) > - indicator_column = -1; > + const int indicator_column = > + fill_column_indicator_column (it, 1) - 1; Why did you need to subtract 1 in the last line? If this is indeed needed, it needs a comment to explain it. > + ATTR_FILTER is the index of a parameter that conditions the merging > + for named faces (case 1) to only the face_ref where > + lface[merge_face_ref] is non-nil. To merge unconditionally set this > + value to 0. ^^ Two spaces between sentences, please. Thanks.