From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] Fix display box cursor under image with margins
Date: Sat, 25 Apr 2020 13:35:35 +0300
Message-ID: <835zdn97k8.fsf@gnu.org>
References: <CAO=W_Zq=LRzRtWszXC=mEf_MTd9uVw+m3up3Q2_7DjuROrQ9VA@mail.gmail.com>
 <83imhwk7sr.fsf@gnu.org>
 <CAO=W_Zp+FgWmW4UMK8aS7epABg=CeRQJqPYSttOV5-+qaV=4pg@mail.gmail.com>
Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202";
	logging-data="106267"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: Evgeny Zajcev <lg.zevlg@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 25 12:36:20 2020
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1jSIAV-000RXR-Vj
	for ged-emacs-devel@m.gmane-mx.org; Sat, 25 Apr 2020 12:36:19 +0200
Original-Received: from localhost ([::1]:34348 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1jSIAV-0000bN-16
	for ged-emacs-devel@m.gmane-mx.org; Sat, 25 Apr 2020 06:36:19 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37328)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>) id 1jSIA0-0008PL-QS
 for emacs-devel@gnu.org; Sat, 25 Apr 2020 06:35:49 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51246)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1jSI9z-0004Am-JE; Sat, 25 Apr 2020 06:35:47 -0400
Original-Received: from [176.228.60.248] (port=2781 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1jSI9y-0007xK-Hq; Sat, 25 Apr 2020 06:35:47 -0400
In-Reply-To: <CAO=W_Zp+FgWmW4UMK8aS7epABg=CeRQJqPYSttOV5-+qaV=4pg@mail.gmail.com>
 (message from Evgeny Zajcev on Sat, 18 Apr 2020 21:05:16 +0300)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:247761
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/247761>

> From: Evgeny Zajcev <lg.zevlg@gmail.com>
> Date: Sat, 18 Apr 2020 21:05:16 +0300
> Cc: emacs-devel <emacs-devel@gnu.org>
> 
>  > Here is the patch to fix issue making cursor hollow under non-mask image, but containing margins. 
>  This
>  > patch keeps box cursor to be box in case image has margins.
> 
>  Could you please give an example of such an image and what the results
>  look like, before and after the patch?  It's hard to understand the
>  details of this otherwise.
> 
> Here is first screenshot how hollow cursor looks on image with margin -
> http://lgarc.narod.ru/pics/emacs-hollow-cursor.png
> 
> And here is how it looks with patch applied - http://lgarc.narod.ru/pics/emacs-box-cursor.png
> 
> Without patch, look of the cursor won't change, it will remain being hollow

Thanks.  Frankly, I'm not sure the change is for the better.

Does anyone else have an opinion?