From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH v2 06/16] Use bset_* functions instead of BVAR
Date: Tue, 01 Dec 2020 19:12:29 +0200
Message-ID: <835z5lih6q.fsf@gnu.org>
References: <20201119153814.17541-1-sbaugh@catern.com>
 <cover.1606009917.git.sbaugh@catern.com>
 <9b43dc231149dc6f272d39d966698b770efb276a.1606009917.git.sbaugh@catern.com>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="30580"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: sbaugh@catern.com, arnold@tdrhq.com, dgutov@yandex.ru,
 monnier@iro.umontreal.ca, emacs-devel@gnu.org
To: Spencer Baugh <sbaugh@catern.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 01 18:13:34 2020
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1kk9DZ-0007pH-Mv
	for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Dec 2020 18:13:33 +0100
Original-Received: from localhost ([::1]:37356 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1kk9DY-0001Zq-PN
	for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Dec 2020 12:13:32 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34296)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1kk9Ce-00018q-9v
 for emacs-devel@gnu.org; Tue, 01 Dec 2020 12:12:36 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58945)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1kk9Cd-0001N3-GM; Tue, 01 Dec 2020 12:12:35 -0500
Original-Received: from [176.228.60.248] (port=3290 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1kk9Cc-0003vs-KY; Tue, 01 Dec 2020 12:12:35 -0500
In-Reply-To: <9b43dc231149dc6f272d39d966698b770efb276a.1606009917.git.sbaugh@catern.com>
 (message from Spencer Baugh on Sat, 21 Nov 2020 21:34:35 -0500)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:260142
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/260142>

> From: Spencer Baugh <sbaugh@catern.com>
> Date: Sat, 21 Nov 2020 21:34:35 -0500
> Cc: Spencer Baugh <sbaugh@catern.com>, Arnold Noronha <arnold@tdrhq.com>,
>  Stefan Monnier <monnier@iro.umontreal.ca>, Dmitry Gutov <dgutov@yandex.ru>
> 
> We move bset_save_length to buffer.h, and expand usage of the
> pre-existing bset_last_selected_window and
> bset_enable_multibyte_characters functions.
> 
> This removes some usage of BVAR as an lvalue, necessary for changing
> BVAR into a function call.

This is problematic.  Inline functions are only fast in optimized
builds, so this punishes people who run unoptimized debug builds,
which is true for many developers.  I'd prefer to have a macro for
that, okay?  And we don't actually need a separate macro for each
variable, right?

Thanks.