From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] Fix some failing tests in BSD systems
Date: Mon, 04 Jan 2021 05:30:30 +0200
Message-ID: <835z4dcrah.fsf@gnu.org>
References: <m1sg7i7xfl.fsf.ref@yahoo.es> <m1sg7i7xfl.fsf@yahoo.es>
 <83a6tpdiuf.fsf@gnu.org> <5e881738-2df3-d5e3-9a46-bc4304ff4092@yandex.ru>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="11540"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org, mardani29@yahoo.es
To: Dmitry Gutov <dgutov@yandex.ru>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 04 04:32:29 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1kwGbd-0002rI-Am
	for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Jan 2021 04:32:29 +0100
Original-Received: from localhost ([::1]:46886 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1kwGbc-0004J7-AG
	for ged-emacs-devel@m.gmane-mx.org; Sun, 03 Jan 2021 22:32:28 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60668)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1kwGZu-0003GM-Dk
 for emacs-devel@gnu.org; Sun, 03 Jan 2021 22:30:42 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53533)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1kwGZu-0007Tq-1L; Sun, 03 Jan 2021 22:30:42 -0500
Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4004
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1kwGZt-0006pn-03; Sun, 03 Jan 2021 22:30:41 -0500
In-Reply-To: <5e881738-2df3-d5e3-9a46-bc4304ff4092@yandex.ru> (message from
 Dmitry Gutov on Mon, 4 Jan 2021 03:41:20 +0200)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:262390
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/262390>

> Cc: emacs-devel@gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Mon, 4 Jan 2021 03:41:20 +0200
> 
> On 03.01.2021 19:35, Eli Zaretskii wrote:
> > Why are we producing file names by concatenation, instead of calling
> > expand-file-name?  Wouldn't using the latter solve the problem?  Or
> > what did I miss?
> 
> While we sometimes do that (expand-file-name is not free, and for 
> certain uses its overhead counts), that doesn't seem to be the case here.

Not sure what you mean: I clearly saw calls to concat in the patch,
both in the old and the new code.  What did I miss?

> The double slash here is produced by an external program, not by 
> concatenation.

I understand that much, but expand-file-name removes the double
slashes as part of its job, doesn't it?