From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] Re: Should (buffer-list) ever return killed buffers?
Date: Mon, 24 May 2021 18:05:03 +0300
Message-ID: <835yz8dvfk.fsf@gnu.org>
References: <87wnrpujo0.fsf@osv.gnss.ru>
 <jwvbl91yq7x.fsf-monnier+emacs@gnu.org> <871r9w5jws.fsf_-_@osv.gnss.ru>
 <83a6okdx60.fsf@gnu.org> <6381ce45-24d5-90f7-c490-7006460f7f43@gmx.at>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="37446"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: cpitclaudel@gmail.com, sorganov@gmail.com, monnier@iro.umontreal.ca,
 emacs-devel@gnu.org
To: martin rudalics <rudalics@gmx.at>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 24 17:05:53 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1llC9R-0009L4-Jh
	for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 17:05:53 +0200
Original-Received: from localhost ([::1]:37574 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1llC9P-00023W-Ci
	for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 11:05:51 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51034)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1llC8h-0001Jm-BA
 for emacs-devel@gnu.org; Mon, 24 May 2021 11:05:07 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40128)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1llC8g-00012k-BX; Mon, 24 May 2021 11:05:06 -0400
Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:5000
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1llC8f-0005dh-TD; Mon, 24 May 2021 11:05:06 -0400
In-Reply-To: <6381ce45-24d5-90f7-c490-7006460f7f43@gmx.at> (message from
 martin rudalics on Mon, 24 May 2021 16:50:48 +0200)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:269763
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/269763>

> Cc: cpitclaudel@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org
> From: martin rudalics <rudalics@gmx.at>
> Date: Mon, 24 May 2021 16:50:48 +0200
> 
>  >> +	(unless (or (nill bufname)
>  >> +		    (eq (aref bufname 0) ?\s) ;; Don't kill internal buffers
>  >>   		    (string-match-p preserve-regexp bufname))
>  >>   	  (kill-buffer buffer)))))
>  >>     (delete-other-windows)
>  >
>  > AFAICT, kill-buffer already is a no-op when the buffer is dead.  So
>  > what exactly does this fix?  (Apologies if I'm missing something: I
>  > cannot say that I've read all the discussions in this thread to the
>  > last detail.)
> 
> Sergey never told us but it's likely `aref' choking on nil.

Then why not use buffer-live-p?