From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: How to add pseudo vector types Date: Sat, 24 Jul 2021 09:51:06 +0300 Message-ID: <835yx019yd.fsf@gnu.org> References: <83h7gw6pyj.fsf@gnu.org> <45EBF16A-C953-42C7-97D1-3A2BFEF7DD01@gmail.com> <83y2a764oy.fsf@gnu.org> <83v95b60fn.fsf@gnu.org> <00DD5BFE-D14E-449A-9319-E7B725DEBFB3@gmail.com> <83r1fz5xr9.fsf@gnu.org> <86mtqh54wo.fsf@stephe-leake.org> <83czrd53z2.fsf@gnu.org> <86wnpj4qh0.fsf@stephe-leake.org> <83lf5z4fwq.fsf@gnu.org> <86fsw4a2tv.fsf@stephe-leake.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39495"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Stephen Leake Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jul 24 08:51:54 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m7BVq-000A4k-1E for ged-emacs-devel@m.gmane-mx.org; Sat, 24 Jul 2021 08:51:54 +0200 Original-Received: from localhost ([::1]:48540 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7BVp-0001KL-3b for ged-emacs-devel@m.gmane-mx.org; Sat, 24 Jul 2021 02:51:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50160) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7BVK-0000e7-KN for emacs-devel@gnu.org; Sat, 24 Jul 2021 02:51:22 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60778) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7BVI-0000En-FJ; Sat, 24 Jul 2021 02:51:20 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4427 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7BVI-0006k0-3D; Sat, 24 Jul 2021 02:51:20 -0400 In-Reply-To: <86fsw4a2tv.fsf@stephe-leake.org> (message from Stephen Leake on Fri, 23 Jul 2021 19:00:12 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271527 Archived-At: > From: Stephen Leake > Cc: casouri@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org > Date: Fri, 23 Jul 2021 19:00:12 -0700 > > Eli Zaretskii writes: > > >> > I fail to see the significance of the difference. Surely, you could > >> > hand it a block of text with changes to mean that this block replaces > >> > the previous version of that block. It might take the parser more > >> > work to update the parse tree in this case, but if it's fast enough, > >> > that won't be the problem. Right? > >> > >> tree-sitter doesn't store the previous text, so there's nothing to > >> compare it to. > > > > There was nothing about comparison in my text. You tell TS that > > editing replaced a block of text between A and B with block between A > > and C, without revealing the fine-grained changes inside that block. > > This must work, because editing could indeed do just that. > > I see; treat the whole block as one change. Yes, that would work, but it > would probably be less optimal than sending a list of smaller changes; > depends on the details. Since TS is very fast, I think this sub-optimality will not cause any tangible performance issues in Emacs. And from our POV it is a good optimization because it will minimize (and to some extent optimize) the traffic between Emacs and TS.