From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: sqlite3 Date: Mon, 06 Dec 2021 21:41:29 +0200 Message-ID: <835ys11pxy.fsf@gnu.org> References: <87tufmjyai.fsf@gnus.org> <87sfv5ljxn.fsf@gnus.org> <8735n5leza.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10213"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 06 20:43:13 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1muJtI-0002T0-QI for ged-emacs-devel@m.gmane-mx.org; Mon, 06 Dec 2021 20:43:12 +0100 Original-Received: from localhost ([::1]:58422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1muJtH-0001Vv-Pc for ged-emacs-devel@m.gmane-mx.org; Mon, 06 Dec 2021 14:43:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52700) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muJrm-00080j-OY for emacs-devel@gnu.org; Mon, 06 Dec 2021 14:41:38 -0500 Original-Received: from [2001:470:142:3::e] (port=38502 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muJrl-0007GG-Cq; Mon, 06 Dec 2021 14:41:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=nVVqL077sycGYJn5168Rcecj7yKVUnzt1ER5Fy/1Itg=; b=eLtz7SDyNqPa a8GX/0I8MpO0e183Ldrf4zvNFOvFcbi0+rrXk9X+4vk5WGlKdsvEvyNPIm9D/0+aFuTlEDkPH9Qm5 +mjzc0Scog+vsp2RTKKky8BrN/ztrI+HkSM48Bd/GoaarVlthPhGokE1xtIvqKYSpgN74B1wyR/Na xhx1YqXPifyA2RgWwyk7d98x8gOiJx6D33KkeFKpBP6n7qOltWEZK4/V6HHxeXyGi5RikQi4LEkBs fL+Tfc5/7CuX/rg4imygctpM+vLw8iusU8Ffif9g6tF+5gslJP4O8chNv+6OGcxwrgcQRfn3yap0g NKwXK8SriRe1ZZzjeXUJGw==; Original-Received: from [87.69.77.57] (port=3146 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muJrf-0006lA-8V; Mon, 06 Dec 2021 14:41:37 -0500 In-Reply-To: <8735n5leza.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 06 Dec 2021 20:18:01 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:281155 Archived-At: > From: Lars Ingebrigtsen > Date: Mon, 06 Dec 2021 20:18:01 +0100 > > It's on the scratch/sqlite branch now, because I wanted to test this on > Macos and Windows... >From what I see there, you completely ignore the text encoding issue. SQLite needs UTF-8, but our internal representation is a superset of UTF-8, so we need to decide what to do with the stuff that's beyond UTF-8. Does SQLite check this and return an error indication if the byte sequence we feed it is not a valid UTF-8? If it does check that, we can rely on it, but we need to signal an error with a clear explanation when it detects something like that. Alternatively, we should check this ourselves before calling SQLite, and signal an error on our own. One other comment is the use of fixnums for integer values. Since SQLite can use the full 64-bit width, I guess we need to use bignums when the value exceeds a fixnum? Thanks.