unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master e0a78429ca: Add a utility function to query the XI2 version on a display
@ 2021-12-25 16:28 Eli Zaretskii
  2021-12-26  1:13 ` Po Lu
  0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2021-12-25 16:28 UTC (permalink / raw)
  To: Po Lu; +Cc: emacs-devel

> branch: master
> commit e0a78429cab632ae269e1845c588506e64e09654
> Author: Po Lu <luangruo@yahoo.com>
> Commit: Po Lu <luangruo@yahoo.com>
> 
>     Add a utility function to query the XI2 version on a display
>     
>     * src/xfns.c (Fx_server_input_version): New function.
>     (syms_of_xfns): Define new subr.

I think a better name for this function would be
x-input-extension-version.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: master e0a78429ca: Add a utility function to query the XI2 version on a display
  2021-12-25 16:28 master e0a78429ca: Add a utility function to query the XI2 version on a display Eli Zaretskii
@ 2021-12-26  1:13 ` Po Lu
  2021-12-26  6:55   ` Eli Zaretskii
  0 siblings, 1 reply; 4+ messages in thread
From: Po Lu @ 2021-12-26  1:13 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

Eli Zaretskii <eliz@gnu.org> writes:

> I think a better name for this function would be
> x-input-extension-version.

How about `x-server-input-extension-version'?  It'll be more consistent
with `x-server-version'.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: master e0a78429ca: Add a utility function to query the XI2 version on a display
  2021-12-26  1:13 ` Po Lu
@ 2021-12-26  6:55   ` Eli Zaretskii
  2021-12-26  7:03     ` Po Lu
  0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2021-12-26  6:55 UTC (permalink / raw)
  To: Po Lu; +Cc: emacs-devel

> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Sun, 26 Dec 2021 09:13:19 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > I think a better name for this function would be
> > x-input-extension-version.
> 
> How about `x-server-input-extension-version'?  It'll be more consistent
> with `x-server-version'.

If you must have the "server" part in the name, fine by me.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: master e0a78429ca: Add a utility function to query the XI2 version on a display
  2021-12-26  6:55   ` Eli Zaretskii
@ 2021-12-26  7:03     ` Po Lu
  0 siblings, 0 replies; 4+ messages in thread
From: Po Lu @ 2021-12-26  7:03 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Po Lu <luangruo@yahoo.com>
>> Cc: emacs-devel@gnu.org
>> Date: Sun, 26 Dec 2021 09:13:19 +0800
>> 
>> Eli Zaretskii <eliz@gnu.org> writes:
>> 
>> > I think a better name for this function would be
>> > x-input-extension-version.
>> 
>> How about `x-server-input-extension-version'?  It'll be more consistent
>> with `x-server-version'.
>
> If you must have the "server" part in the name, fine by me.

Thanks, now done.



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-12-26  7:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-25 16:28 master e0a78429ca: Add a utility function to query the XI2 version on a display Eli Zaretskii
2021-12-26  1:13 ` Po Lu
2021-12-26  6:55   ` Eli Zaretskii
2021-12-26  7:03     ` Po Lu

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).