From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix placement of toggle and radio button in Lucid menu. Date: Thu, 24 Feb 2022 12:36:13 +0200 Message-ID: <835yp4sg9u.fsf@gnu.org> References: <87sfs87i5o.fsf@elite.giraud> <87pmnc7f5c.fsf@yahoo.com> <87k0dk7ejd.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19162"; mail-complaints-to="usenet@ciao.gmane.io" Cc: manuel@ledu-giraud.fr, emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 24 11:36:56 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nNBUV-0004n1-Rh for ged-emacs-devel@m.gmane-mx.org; Thu, 24 Feb 2022 11:36:56 +0100 Original-Received: from localhost ([::1]:40660 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nNBUU-0003e8-1q for ged-emacs-devel@m.gmane-mx.org; Thu, 24 Feb 2022 05:36:54 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50496) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNBTj-0002yA-BI for emacs-devel@gnu.org; Thu, 24 Feb 2022 05:36:09 -0500 Original-Received: from [2001:470:142:3::e] (port=38218 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNBTh-0003FX-OB; Thu, 24 Feb 2022 05:36:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=c94rXod8/YWbUSptKWtdCsaMo5tHD3tj7O/OGamEcvQ=; b=YjBwlskSQXjt bmmGHljnpgEhIK9lnneNrxzHXs/FReQm/kJRu5h8QXqwv/TUPcfax+lzbNd7MYOr0uepxcH+SR6jb NNDtsonPIWWWl+zXcUO6HWPy4YwW/Z3Xq4tREiaFb76kZ+62uw3SzAg5IHGpUVUyAs5Cv+9qzAWt/ lSewx1hEfeqasc5ZUWmGauuvy25nZC3iu7JcG8nAAuaBYY3pQ4dPz4Z34FVrzU+53jtbsD3H9Pmvj /YSYeKyA7X81HnQ+e312FXOYOZ7P1jn1dQPq6ArlIDQXL2IMnb+ZmD+OqomWISiFt09yG5aioG+dd y9i8GxKgFczkMypMV0FY5A==; Original-Received: from [87.69.77.57] (port=4722 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNBTd-0001LT-QJ; Thu, 24 Feb 2022 05:36:03 -0500 In-Reply-To: <87k0dk7ejd.fsf@yahoo.com> (message from Po Lu on Thu, 24 Feb 2022 18:19:18 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286661 Archived-At: > From: Po Lu > Cc: emacs-devel > Date: Thu, 24 Feb 2022 18:19:18 +0800 > > Po Lu writes: > > > Those buttons are supposed to be placed relative to the descent line, > > not the bottom of the text field. So that's not a bug. > > Sorry, I meant that they are supposed to be relative to the baseline. That's true, but I wonder how come this code produces such high position of the buttons? It doesn't look like the button is centered relative to the "middle" of the first character of the menu item's label. Can you or Manuel show the values of the font's ascent/descent vs the actual metrics of the upper-case characters shown on the screenshots, such as 'H', 'C', and 'S'?