From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: master b1e9151: Enable the native display of BMP images on Haiku
Date: Sat, 26 Mar 2022 15:29:37 +0300
Message-ID: <835yo0c2xa.fsf@gnu.org>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="30796"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: Po Lu <luangruo@yahoo.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 26 13:33:04 2022
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1nY5bL-0007pA-Pn
	for ged-emacs-devel@m.gmane-mx.org; Sat, 26 Mar 2022 13:33:04 +0100
Original-Received: from localhost ([::1]:32984 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1nY5bK-0000Wl-NW
	for ged-emacs-devel@m.gmane-mx.org; Sat, 26 Mar 2022 08:33:02 -0400
Original-Received: from eggs.gnu.org ([209.51.188.92]:52748)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1nY5YD-0007UF-HQ
 for emacs-devel@gnu.org; Sat, 26 Mar 2022 08:29:50 -0400
Original-Received: from [2001:470:142:3::e] (port=55678 helo=fencepost.gnu.org)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nY5Y4-0004Mw-Al; Sat, 26 Mar 2022 08:29:48 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=Subject:To:From:Date:mime-version:in-reply-to:
 references; bh=CCP14A5CQqLP+w9F1Nio3eu3it+Ge7x68G3LyKe/EHI=; b=qnwe8YS7YeDz46
 2Lpy1Dr0DXlxqfNgDb49sF5ZYAHqPoXzNDeJ8Onrvxwez9Qa7HrXLuXZ4ZI/7Cj85+atAFR/rSCbd
 evwS1yQeKTGyyxvvoX8OJAE5CqPbiyXLwHRJ1D0QuFQ4m6WlZ27Rv+QFIp5FAmcha5i4JP5fUWqih
 mqsEZa+Ep/+JEX8wBpFBcVNqWyJ0U0pz74zeT9hcVZbVnNUg4lWyap0M3iQZh6ty4k5+imtiGbeYs
 pNp1ct9Gm/3lG14unD1SHCLuwlvmmUGfUrkMe6BJ+p7/e3MvZJCoS8K3q76oaBVF4/t38+JvULlCK
 OORWTs1IFamn6ANQm8WA==;
Original-Received: from [87.69.77.57] (port=1238 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nY5Y3-0000kj-N6; Sat, 26 Mar 2022 08:29:40 -0400
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:287476
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/287476>

> --- a/src/image.c
> +++ b/src/image.c
> @@ -11555,12 +11555,16 @@ syms_of_image (void)
> 
>  #if HAVE_NATIVE_IMAGE_API
>    DEFSYM (Qnative_image, "native-image");
> -# ifdef HAVE_NTGUI
> -  DEFSYM (Qgdiplus, "gdiplus");
> -  DEFSYM (Qshlwapi, "shlwapi");
> +
> +#if defined HAVE_NTGUI || defined HAVE_HAIKU
>    DEFSYM (Qbmp, "bmp");
>    add_image_type (Qbmp);
> -# endif
> +#endif
> +
> +#ifdef HAVE_NTGUI
> +  DEFSYM (Qgdiplus, "gdiplus");
> +  DEFSYM (Qshlwapi, "shlwapi");
> +#endif
>  #endif
> 
>    defsubr (&Sinit_image_library);

Shouldn't you now remove SEFSYM for Qbmp from haikuimage.c?