From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 2ef6f943abd: Add option to control default outlining in 'C-h b' Date: Tue, 25 Apr 2023 14:44:06 +0300 Message-ID: <835y9kw5ix.fsf@gnu.org> References: <168233653969.13461.3810563138120581789@vcs2.savannah.gnu.org> <20230424114219.F2AEAC0004A@vcs2.savannah.gnu.org> <877cu1bf6q.fsf@gmail.com> <834jp5xn7v.fsf@gnu.org> <87a5ywn4qj.fsf@web.de> <83r0s8wjcf.fsf@gnu.org> <87leig9xm8.fsf@gmail.com> <838regwcnt.fsf@gnu.org> <87fs8o9spe.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34860"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, emacs-devel@gnu.org, orontee@gmail.com To: Robert Pluim , Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 25 13:44:37 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1prH64-0008pF-Am for ged-emacs-devel@m.gmane-mx.org; Tue, 25 Apr 2023 13:44:36 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1prH5E-0001BF-F8; Tue, 25 Apr 2023 07:43:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prH5C-0001Ar-0V for emacs-devel@gnu.org; Tue, 25 Apr 2023 07:43:42 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prH5B-00055d-A7; Tue, 25 Apr 2023 07:43:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=D/9o7jm3NpKeIICvsYRky3pbddzldR8QULfGUjwF1lk=; b=WsWP3TU3kcHp Zykg+Rd02ZHaiuDSEJtw2l9ds7hJKW8/f/SH8B0yzPVkzTgKpm613aKpXrt4UaeUzJAWCoboARIrW wE4ZLJhSpYwjJj31cZBNejzQM5DVdcTZgA+Ob751MqXe6YjBSbx5mjDRh0seNNbJMR77JLloTbxtY pLuf/DVV+3qSIO75DcoYKyxflCg/n+EIDcVH1mevJHVsY4FEm7Bn7NNU2bQFM/JNSlx9MIAOv6hPp 1RV6RDS3jpCdfJr+LVnnPM/5OLy5p5Q+a06JqGu//xWhaEX+tcSn+dvg9C218CMIb+7OHe4hK474k Sx1msvTpZ5+WdjcZmN/nrQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prH5A-00047k-Oj; Tue, 25 Apr 2023 07:43:41 -0400 In-Reply-To: <87fs8o9spe.fsf@gmail.com> (message from Robert Pluim on Tue, 25 Apr 2023 12:11:57 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305647 Archived-At: > From: Robert Pluim > Cc: michael_heerdegen@web.de, emacs-devel@gnu.org, orontee@gmail.com > Date: Tue, 25 Apr 2023 12:11:57 +0200 > > >>>>> On Tue, 25 Apr 2023 12:09:58 +0300, Eli Zaretskii said: > > >> This code and the defcustom is new in emacs-29, so we can still change > >> it to be a predicate instead. At least we should document is better > > Eli> Agreed. Patches welcome. > > I assumed you were agreeing to the code change, which looks like this: No objections, unless some code is already using this with a function that doesn't return a boolean. Matthias, Juri: any objections or comments?