From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Adding support for xref jumping to headers/interfaces Date: Fri, 23 Jun 2023 08:52:52 +0300 Message-ID: <835y7e3etn.fsf@gnu.org> References: <83pm9sfxfa.fsf@gnu.org> <861qm4tkih.fsf@stephe-leake.org> <71ea5e83-183f-2ae3-8146-6a31045a0309@yandex.ru> <834jqzafse.fsf@gnu.org> <83h6uv47e8.fsf@gnu.org> <4639d7ca-2109-864c-33c0-38e65f26f262@yandex.ru> <835ybb3txt.fsf@gnu.org> <83wn3q311i.fsf@gnu.org> <412afa2d-5dbc-52da-39c4-99be3873929c@yandex.ru> <83o7p20wdi.fsf@gnu.org> <72b09256-5a1b-8962-9e3c-7d2ffd0dc0d7@yandex.ru> <83ilf925n8.fsf@gnu.org> <95afa441-18ae-e62a-be16-be73a545bbba@yandex.ru> <81c2ff07-c5e2-fb3a-5945-049a307bff84@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17398"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Spencer Baugh Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 23 07:53:45 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qCZjt-0004LV-Dh for ged-emacs-devel@m.gmane-mx.org; Fri, 23 Jun 2023 07:53:45 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qCZiy-0002Zv-AQ; Fri, 23 Jun 2023 01:52:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCZir-0002Zh-Pa for emacs-devel@gnu.org; Fri, 23 Jun 2023 01:52:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCZir-0001qN-0W; Fri, 23 Jun 2023 01:52:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=BZ5DLmgASWldrGOXRH6faXKRveQPuHbFf3x1SO7z0lE=; b=GaBXT5XCa29IC0YseEc2 us/x0CvJLYY5mGNvW0bEnm/coheTedsGOoOUJL47C2krUUyivkBvhS0TRP2ir5QUNDaBF37hE2thy GWcE1H7UoP7J6y62V7jsHPISwc3A0juutB+CgwZ4HHwxF/CjVxb57f1kGZMaABmpUerkYsxh7LMIS wWv6f5hXMu2iPdvi0pm4q3sUcwf9nt9kZVEsVlN1Ppn+LWbRmNbO4i+AdQ0r5loHP6DHDFA2JU1+b jeZKqsBblMKUvfhrRahoTxocW4bX/A9a2h3FCiqKlt+E3c4lKAGCKdV3gxxVMF120pVxLGToeUNEE lYPx21Ndw4KiSg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCZip-0002wU-82; Fri, 23 Jun 2023 01:52:40 -0400 In-Reply-To: (message from Spencer Baugh on Thu, 22 Jun 2023 15:22:25 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:307144 Archived-At: > From: Spencer Baugh > Date: Thu, 22 Jun 2023 15:22:25 -0400 > > João Távora writes: > > On Sat, Jun 17, 2023 at 2:54 AM Dmitry Gutov wrote: > >> It is of course the prerogative of the backend to choose which locations > >> to return as the list of definitions. Some backends/languages might as > >> well include interfaces in the list. > >> > >> One problem with that, though, is that we're doing some things > >> differently from SLIME. In particular, we try to make it easy to jump to > >> a specific definition as quickly as possible. > > > > I see no problem with that, but it might be interesting to keep the > > backend plug-in mechanisms generic enough to eventually enable > > different types of UI. > > Do you envision that eglot-find-typeDefinition would also be covered by > xref-find-definitions in this way? The type defintion feels a bit > different from others. > > In any case, it seems to me that C-u M-. would be a good way to say > "return all different kinds of definitions" to xref-find-definitions. > Then the user could just switch to the one they want in the *xref* > buffer. This keeps the basic M-. operation fast, while making it easy > to jump to other kinds of definitions. Seems perfect. Why does this need a separate key sequence? M-. already knows how to cope with more than a single candidate returned by the backend. How is this case different?