From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Adding support for xref jumping to headers/interfaces Date: Mon, 27 Nov 2023 18:37:28 +0200 Message-ID: <8359fa1e-fb63-dac5-067b-aae9c82e4ca9@gutov.dev> References: <87il697r5g.fsf@catern.com> <87r0kw8nxu.fsf@catern.com> <3fe5a8cd-b355-d7eb-10ad-8846aef3387b@gutov.dev> <878r6mx1xc.fsf@betli.tmit.bme.hu> <90e4b9a7-3b51-587d-e317-b89e5d5464d9@gutov.dev> <87sf4scxax.fsf@betli.tmit.bme.hu> <77500777-aea2-14db-4aab-7a5dff43443b@gutov.dev> <83o7ff8bc4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24953"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: joaotavora@gmail.com, felician.nemeth@gmail.com, sbaugh@janestreet.com, emacs-devel@gnu.org, me@eshelyaron.com, john@yates-sheets.org, spacibba@aol.com, fgunbin@fastmail.fm To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 27 17:38:59 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r7edO-0006CG-68 for ged-emacs-devel@m.gmane-mx.org; Mon, 27 Nov 2023 17:38:58 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r7ec8-0002Tg-Io; Mon, 27 Nov 2023 11:37:40 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r7ec4-0002TA-Jr for emacs-devel@gnu.org; Mon, 27 Nov 2023 11:37:36 -0500 Original-Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r7ec2-0007t4-Ld; Mon, 27 Nov 2023 11:37:36 -0500 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BB5665C02A3; Mon, 27 Nov 2023 11:37:32 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 27 Nov 2023 11:37:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1701103052; x=1701189452; bh=gB2OeG5cH5E6z5SBGLL4P+iAGI3yDm7RBC0 OnXnlTTg=; b=CSov3JyXdPtW/elu1UgM97ZGZq3BIF3Rbclg3i5PpLYvNtouGbo k3M3bTqAnEj46s5lD+KfbGVu801DYemFEae+J2aQKlT7zu1lphqHBvFUnlIzseW8 /PpYO/dkh8KSN9T/53vY7g34IambsKX6MHzhaOwT8aE0VXCLTo4F5eRvM3rI+ppC up6F6UZcXUpV2jioHvc0PBA7/UOSzXW/qgJdEViFB0eegQb4ov1C4ZVI68CI7qCn cKIQjm1GXzT6rmefv82gEmwGUthvBrQdpa1V1oJx/gMQszLcUsHiJyI5jhKaFXVB tezgs2LwGUK9SOwksRiZ+PnNQzISQ9qsdhQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1701103052; x=1701189452; bh=gB2OeG5cH5E6z5SBGLL4P+iAGI3yDm7RBC0 OnXnlTTg=; b=VBVk5wfeT09AfAKBfogdrZc3PqTq3zUiCFOulzR3stqEZAIRKlh 1HA7ATeHtu63OKfe4dQs5ceF2GpUtJVWJXQrw/9YZv05KTs+K1oQZI7k9lsh//Q/ ecXESaso247lq20Aoiziyo3tZgmZTKBx5JICj2jrva3s2whhuzDYhNmSgZDnn8ei DcLf4I2BZzCvIGthaITG5iU3X6b5KVIpM2goy3k5h8xxCbccJlyK+JkFrGys5EpW EfhmEZGTgHKDa4YVHM2vDP5we7bxWOuKct6A2lpYFUgrb3A384OBzuIMjFSG0Nvp QeWNIMHkwI3R2hsD7lUS9bAgx0b4TdcAQlA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeiuddgleduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhephfffheeljeffgeffueeghfekkedtfffgheejvdegjeettdduheeufffggfef jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 27 Nov 2023 11:37:30 -0500 (EST) Content-Language: en-US In-Reply-To: <83o7ff8bc4.fsf@gnu.org> Received-SPF: pass client-ip=66.111.4.29; envelope-from=dmitry@gutov.dev; helo=out5-smtp.messagingengine.com X-Spam_score_int: -46 X-Spam_score: -4.7 X-Spam_bar: ---- X-Spam_report: (-4.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.857, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313284 Archived-At: On 27/11/2023 17:28, Eli Zaretskii wrote: >> Date: Mon, 27 Nov 2023 17:01:58 +0200 >> Cc: Felician Nemeth, >> Spencer Baugh,emacs-devel@gnu.org, >> Eshel Yaron, John Yates, >> Ergus, Filipp Gunbin >> From: Dmitry Gutov >> >> On 27/11/2023 16:49, João Távora wrote: >>> On Mon, Nov 27, 2023 at 2:43 PM Dmitry Gutov wrote: >>> >>>> (that's what the completing-read approach is for), and whenever we find >>>> out that particular kinds get supported by many backends (or by most of >>>> the available/popular ones), we could "pull them into the core", adding >>>> a global command with one binding which would work across languages. >>> Alright, so since this is contentious (who else but you is pushing >>> this idea?) >> Indeed, I wonder if nobody else is interested in having the additional >> commands have pre-defined bindings, or having the same bindings across >> languages. > I might be interested, but you guys have a tendency to drown the > important issues in an ocean of second- and third-order stuff. It is > very hard to follow this discussion, with its longish posts and a lot > of barely-related issues and arguments. That's moderately insulting. To me, at least. > Maybe it's time to post some kind of summary? I just posted a summary on 24/11/2023, 03:37 +02:00. Do you perhaps have any questions related to it? One of the disagreements is on whether Xref should have any new kind-commands, such as xref-find-declarations, xref-find-implemenetation and xref-find-type-definitions which you can find on the branch feature/xref-find-extra (the diff is not big, you can take a look). Or whether definitions like that should be reimplemented by every Xref backend that wants to use them, and the backends would themselves pick the key bindings for them (or leave unbound). The usefulness of this also depends on whether we can appoint a comfortable binding for the prefix map for the new commands. In the prototype I've used "M-'" -- a binding currently occupied by a command that I've never used in my life, which others here seemed to agree with -- but any other alternative can be considered, of course.