From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Changes in frame/window code Date: Wed, 20 Aug 2014 17:45:38 +0300 Message-ID: <834mx7cj8t.fsf@gnu.org> References: <53CE6A44.1010708@gmx.at> <83egx5h86z.fsf@gnu.org> <53D68806.9080101@gmx.at> <838undgxiu.fsf@gnu.org> <53D76758.2030707@gmx.at> <831tt4h58x.fsf@gnu.org> <83y4vcfoqi.fsf@gnu.org> <53D77BDB.1090500@gmx.at> <83wqawflgj.fsf@gnu.org> <53D7A981.30909@gmx.at> <83lhrctdzr.fsf@gnu.org> <53D7C10C.4010402@gmx.at> <83k36wta5m.fsf@gnu.org> <53D7E6B0.7040504@gmx.at> <83egx4t3nq.fsf@gnu.org> <53D917B5.2050604@gmx.at> <837g2uu80w.fsf@gnu.org> <53D9211C.7010000@gmx.at> <834mxyu5jg.fsf@gnu.org> <53D92D04.3010006@gmx.at> <83zjfqspfw.fsf@gnu.org> <53DA0310.4010706@gmx.at> <53DA15C4.5050006@gmx.at> <83mwbpss6s.fsf@gnu.org> <53DA29EC.3000504@gmx.at> <837g2ssg30.fsf@gnu.org> <53DB6B08.7000305@gmx.at> <834mxws6a0.fsf@gnu.org> <53DBB268.2020909@gmx.at> <831tt0rwyp.fsf@gnu.org> <53EE2CD5.50603@gmx.a> <83tx5demej.fsf@gnu.org> <53EF25F2.9010909@gmx.at> <83iolsekqd.fsf@gnu.org> <53EF609C.2090303@gmx> <83wqa7cfoy.fsf@gnu.org> <53F1B9EA.6030808@gmx.at> <83lhqldeqf.fsf@gnu.org> <53F225A7.6030103@gmx.at> <83ha19day1.fsf@gnu.org> <83bnrgcxxt.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1408545981 13441 80.91.229.3 (20 Aug 2014 14:46:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 20 Aug 2014 14:46:21 +0000 (UTC) Cc: emacs-devel@gnu.org To: rudalics@gmx.at Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 20 16:46:14 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XK79R-0000aJ-Co for ged-emacs-devel@m.gmane.org; Wed, 20 Aug 2014 16:46:13 +0200 Original-Received: from localhost ([::1]:56096 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XK79R-00082r-1m for ged-emacs-devel@m.gmane.org; Wed, 20 Aug 2014 10:46:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47459) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XK798-00082l-5x for emacs-devel@gnu.org; Wed, 20 Aug 2014 10:46:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XK78y-0001YN-Bk for emacs-devel@gnu.org; Wed, 20 Aug 2014 10:45:54 -0400 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:57807) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XK78x-0001Y6-T7 for emacs-devel@gnu.org; Wed, 20 Aug 2014 10:45:44 -0400 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NAM00G000PW5R00@a-mtaout21.012.net.il> for emacs-devel@gnu.org; Wed, 20 Aug 2014 17:45:42 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NAM00FO1105UZ70@a-mtaout21.012.net.il>; Wed, 20 Aug 2014 17:45:42 +0300 (IDT) In-reply-to: <83bnrgcxxt.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:173778 Archived-At: > Date: Tue, 19 Aug 2014 18:15:58 +0300 > From: Eli Zaretskii > Cc: emacs-devel@gnu.org > > Btw, I don't understand why in w32_horizontal_scroll_bar_handle_click > you overwrite the value reported from GetScrollInfo by > HIWORD(msg->msg.wParam). My reading of MSDN documentation is that > they recommend to do it the other way around, since GetScrollInfo is > not limited to 16-bit values. If using the values reported by > GetScrollInfo doesn't work well, perhaps that's because for > SB_THUMBTRACK message you need to use SIF_TRACKPOS and si.nTrackPos > rather than SIF_POS and si.nPos. I switched to using the GetScrollInfo information (for both horizontal and vertical scroll bars) in trunk revision 117716. I didn't find any reason for the current code, except, perhaps, the fact that an old version of MSDN documentation didn't document SIF_TRACKPOS at all. But since even the venerable "Programming Windows" by Petzold that was published in 1998 described that value very well without any qualifications for its support by various Windows versions we care about, I think it's safe to use it.