From: Eli Zaretskii <eliz@gnu.org>
To: Matthew Leach <matthew@mattleach.net>
Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org
Subject: Re: [PATCH v5] Add systemd socket launching support
Date: Sat, 16 Apr 2016 12:50:27 +0300 [thread overview]
Message-ID: <834mb1dgrg.fsf@gnu.org> (raw)
In-Reply-To: <871t6do8w1.fsf@mattleach.net> (message from Matthew Leach on Sun, 10 Apr 2016 15:06:54 +0100)
> From: Matthew Leach <matthew@mattleach.net>
> Cc: Eli Zaretskii <eliz@gnu.org>, Stefan Monnier <monnier@IRO.UMontreal.CA>
> Date: Sun, 10 Apr 2016 15:06:54 +0100
>
> Here is a new version of the systemd integration & socket-launching
> patches. The main change in this series is providing an interface for
> other socket-launching applications to be integrated, namely
> `set_external_socket_descriptor' in process.c.
>
> Feedback & comments welcome!
Thanks, I pushed it to the master branch.
I think it would make sense to add this feature to the list in
EMACS_CONFIG_FEATURES (see the configure script for how we generate
that list).
A few minor comments, for the future:
. Be consistent in how you quote symbols in the log entries. In this
submission, you sometimes quoted `like this', sometimes 'like
this', and sometimes left the symbols unquoted. Pick one style and
stick to it.
. The way to call out a function name is 'function' (with quotes).
The GNU Coding Standards frown upon using function(), which looks
like a call to the function with no arguments, not what you mean.
Thanks again for working on this.
next prev parent reply other threads:[~2016-04-16 9:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-10 14:06 [PATCH v5] Add systemd socket launching support Matthew Leach
2016-04-14 17:54 ` Matthew Leach
2016-04-17 5:42 ` Paul Eggert
2016-04-17 11:30 ` Matthew Leach
2016-04-18 5:44 ` Paul Eggert
2016-04-18 19:33 ` Matthew Leach
2016-04-21 20:59 ` Matthew Leach
2016-04-26 9:17 ` Matthew Leach
2016-04-26 16:15 ` Paul Eggert
2016-04-27 9:56 ` Matthew Leach
2016-04-16 9:50 ` Eli Zaretskii [this message]
2016-04-17 11:15 ` Matthew Leach
2016-04-21 16:17 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834mb1dgrg.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=matthew@mattleach.net \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).