unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-25 1c58fa1: Fix variable-pitch font on MS-Windows
Date: Sat, 30 Apr 2016 17:03:19 +0300	[thread overview]
Message-ID: <834majp520.fsf@gnu.org> (raw)
In-Reply-To: <jwvtwij6wu4.fsf-monnier+emacsdiffs@gnu.org> (message from Stefan Monnier on Sat, 30 Apr 2016 09:48:32 -0400)

> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Sat, 30 Apr 2016 09:48:32 -0400
> 
> > -  '((t :family "Sans Serif"))
> > +  '((((type w32))
> > +     ;; This is a kludgey workaround for an issue discussed in
> > +     ;; http://lists.gnu.org/archive/html/emacs-devel/2016-04/msg00746.html.
> > +     :font "-outline-Arial-normal-normal-normal-sans-*-*-*-*-p-*-iso8859-1")
> > +    (t :family "Sans Serif"))
> 
> This is really curious.  Why does Emacs pick a bold-italic face when we
> don't specify bold (nor italic)?

I have no idea.  My best guess is that bold-italic font variant is the
first one that Emacs finds, but I have no evidence to support that
guess.

One thing is clear: Emacs doesn't know that the resulting face is
bold-italic, because manually forcing the corresponding attributes to
be "normal"/"roman" doesn't fix this.  (Specifying those attributes
explicitly was a solution I tried first, because it seems like less
ugly.)

> I understand that the above defface doesn't explicitly specify ":slanted
> nil", but it's still very puzzling.

I very much agree.  Unfortunately, font selection logic is something I
have only a very vague idea about.  The change which apparently caused
this as side effect was for a similar (and more serious) problem, and
the solution I found was just a heuristic, by watching the fonts that
were examined and rejected.



  reply	other threads:[~2016-04-30 14:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160430095647.11601.56460@vcs.savannah.gnu.org>
     [not found] ` <E1awRdn-00031p-5c@vcs.savannah.gnu.org>
2016-04-30 13:48   ` [Emacs-diffs] emacs-25 1c58fa1: Fix variable-pitch font on MS-Windows Stefan Monnier
2016-04-30 14:03     ` Eli Zaretskii [this message]
2016-04-30 14:33       ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834majp520.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).