From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Refactor digest authentication in url-auth Date: Sat, 18 Feb 2017 13:11:45 +0200 Message-ID: <834lzrrbwu.fsf@gnu.org> References: <1487106777-17025-1-git-send-email-jarno@malmari.fi> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1487416283 23121 195.159.176.226 (18 Feb 2017 11:11:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 18 Feb 2017 11:11:23 +0000 (UTC) Cc: emacs-devel@gnu.org To: Jarno Malmari Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 18 12:11:19 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf2v8-0005Tv-HV for ged-emacs-devel@m.gmane.org; Sat, 18 Feb 2017 12:11:18 +0100 Original-Received: from localhost ([::1]:58069 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cf2vE-000845-D1 for ged-emacs-devel@m.gmane.org; Sat, 18 Feb 2017 06:11:24 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cf2v8-00083y-Cd for emacs-devel@gnu.org; Sat, 18 Feb 2017 06:11:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cf2v5-0007w7-8h for emacs-devel@gnu.org; Sat, 18 Feb 2017 06:11:18 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44478) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cf2v5-0007vm-53; Sat, 18 Feb 2017 06:11:15 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1220 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cf2v4-0000XF-Dk; Sat, 18 Feb 2017 06:11:14 -0500 In-reply-to: <1487106777-17025-1-git-send-email-jarno@malmari.fi> (message from Jarno Malmari on Tue, 14 Feb 2017 23:12:55 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:212445 Archived-At: > From: Jarno Malmari > Cc: eliz@gnu.org > Date: Tue, 14 Feb 2017 23:12:55 +0200 > > Here's a revised patch set for the earlier digest auth work. > > * Changed comments to follow gnu coding standards: two spaces between > sentences, capital letter at beginning, period at the end, and the > like > > * Removed bunch of references to RFC 2617 from docstrings. Still to > understand what's being done requires you to pick that up, but > mentioning it repeatedly doesn't help too much. > > * Changed the format of commit messages. > > * There were talk about what to call the "path component of an URI". > Is it file-name part, directory, path, or URI path. I tried avoiding > mentioning it but a few references remains and I ended up choosing > "directory" since that's what's used in functions used here, namely: > > (url-file-directory (url-filename url)) > > The `url-file-directory' is defined in url-util with docstring: > > "Return the directory part of FILE, for a URL." > > Patches that follows: > [PATCH 1/2] Refactor digest authentication in url-auth > [PATCH 2/2] Initial implementation for HTTP Digest qop for url Thanks. Could someone familiar with url-auth.el please review these?