From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 885c512: Fix a bug in 'generate-new-buffer-name' Date: Sat, 05 Aug 2017 18:58:37 +0300 Message-ID: <834ltmuhua.fsf@gnu.org> References: <20170805095359.14455.50578@vcs0.savannah.gnu.org> <20170805095400.0316E20660@vcs0.savannah.gnu.org> <83lgmyupzv.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1501948774 30778 195.159.176.226 (5 Aug 2017 15:59:34 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 5 Aug 2017 15:59:34 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 05 17:59:31 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1de1UA-0007ku-Lj for ged-emacs-devel@m.gmane.org; Sat, 05 Aug 2017 17:59:30 +0200 Original-Received: from localhost ([::1]:57309 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1de1UG-0000f5-Tj for ged-emacs-devel@m.gmane.org; Sat, 05 Aug 2017 11:59:36 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49143) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1de1TV-0000eh-B7 for emacs-devel@gnu.org; Sat, 05 Aug 2017 11:58:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1de1TS-0001jf-90 for emacs-devel@gnu.org; Sat, 05 Aug 2017 11:58:49 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51924) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1de1TS-0001jY-4w; Sat, 05 Aug 2017 11:58:46 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2589 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1de1TR-0007mv-KB; Sat, 05 Aug 2017 11:58:46 -0400 In-reply-to: (message from Stefan Monnier on Sat, 05 Aug 2017 11:14:30 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217325 Archived-At: > From: Stefan Monnier > Cc: emacs-devel@gnu.org > Date: Sat, 05 Aug 2017 11:14:30 -0400 > > >> > - if (!NILP (Fstring_equal (name, ignore)) || NILP (Fget_buffer (name))) > >> > + if ((!NILP (ignore) && !NILP (Fstring_equal (name, ignore))) > >> > + || NILP (Fget_buffer (name))) > >> Why not just use Fequal instead of Fstring_equal? > > Because no one said that using a symbol for the IGNORE argument is > > forbidden in that function. "nil" just happens to be a special case, > > but other strings/symbols are allowed. > > I'd be surprised if there is code out there that uses a symbol for the > `ignore` argument. And I don't think it's a feature that you can use > a symbol rather than a string. I think it's rather a (harmless (except > for nil)) bug. Maybe so, but I see no real reason to switch to using Fequal, either.