From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Emacs26: Quick thoughts on display-line-numbers-mode Date: Fri, 06 Oct 2017 10:26:19 +0300 Message-ID: <834lrcwxd0.fsf@gnu.org> References: <83h8vdwh7t.fsf@gnu.org> <83d161wenj.fsf@gnu.org> <1507259379.15251.27.camel@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1507274830 18936 195.159.176.226 (6 Oct 2017 07:27:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 6 Oct 2017 07:27:10 +0000 (UTC) Cc: rswgnu@gmail.com, emacs-devel@gnu.org To: Matthew Plant Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 06 09:27:02 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0N2C-0003lh-Kt for ged-emacs-devel@m.gmane.org; Fri, 06 Oct 2017 09:27:00 +0200 Original-Received: from localhost ([::1]:43348 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0N2J-0005XC-E0 for ged-emacs-devel@m.gmane.org; Fri, 06 Oct 2017 03:27:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48298) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0N1k-0005X7-2r for emacs-devel@gnu.org; Fri, 06 Oct 2017 03:26:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0N1g-0008Nh-Ux for emacs-devel@gnu.org; Fri, 06 Oct 2017 03:26:32 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37084) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0N1g-0008NW-RU; Fri, 06 Oct 2017 03:26:28 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4462 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e0N1g-0008Ks-9B; Fri, 06 Oct 2017 03:26:28 -0400 In-reply-to: <1507259379.15251.27.camel@gmail.com> (message from Matthew Plant on Thu, 05 Oct 2017 20:09:39 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219165 Archived-At: > From: Matthew Plant > Cc: emacs-devel@gnu.org > Date: Thu, 05 Oct 2017 20:09:39 -0700 > > > There's a technical problem with doing that, for which I didn't have > > a > > solution at the time and still don't. Such an option would also slow > > redisplay, albeit in minor ways. > > > For now, you can go to src/xdisp.c:20996 and change the line: > strcat (lnum_buf, " "); > to > strcat (lnum_buf, "|"); The problem with this is that in R2L paragraphs the glyph should _precede_ the number, i.e. be to the left of the number. And when the number is generated for the first line to be redrawn, the paragraph direction was not yet computed. This is the technical problem to which I alluded. Until I find a way to solve it, such solutions cannot be accepted, sorry. > Although I think I like the pipe character better than the space. That definitely depends on the font you are using. Some fonts have an extremely ugly pipe glyphs. So this will have to be another customization option, not just a hard-coded character.