unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Matthew Plant <maplant95@gmail.com>
Cc: rswgnu@gmail.com, emacs-devel@gnu.org
Subject: Re: Emacs26: Quick thoughts on display-line-numbers-mode
Date: Fri, 06 Oct 2017 10:26:19 +0300	[thread overview]
Message-ID: <834lrcwxd0.fsf@gnu.org> (raw)
In-Reply-To: <1507259379.15251.27.camel@gmail.com> (message from Matthew Plant on Thu, 05 Oct 2017 20:09:39 -0700)

> From: Matthew Plant <maplant95@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Thu, 05 Oct 2017 20:09:39 -0700
> 
> > There's a technical problem with doing that, for which I didn't have
> > a
> > solution at the time and still don't.  Such an option would also slow
> > redisplay, albeit in minor ways.
> > 
> For now, you can go to src/xdisp.c:20996 and change the line:
>     strcat (lnum_buf, " ");
> to  
>    strcat (lnum_buf, "|");

The problem with this is that in R2L paragraphs the glyph should
_precede_ the number, i.e. be to the left of the number.  And when the
number is generated for the first line to be redrawn, the paragraph
direction was not yet computed.  This is the technical problem to
which I alluded.  Until I find a way to solve it, such solutions
cannot be accepted, sorry.

> Although I think I like the pipe character better than the space.

That definitely depends on the font you are using.  Some fonts have an
extremely ugly pipe glyphs.  So this will have to be another
customization option, not just a hard-coded character.



  reply	other threads:[~2017-10-06  7:26 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-05 18:38 Emacs26: Quick thoughts on display-line-numbers-mode Robert Weiner
2017-10-05 18:52 ` Matthew Plant
2017-10-05 19:13   ` Eli Zaretskii
     [not found]     ` <1507232129.15251.12.camel@gmail.com>
2017-10-05 19:50       ` Eli Zaretskii
2017-10-05 20:07         ` Matthew Plant
2017-10-05 23:24         ` Alex
2017-10-06  6:48           ` Eli Zaretskii
2017-10-07 21:12             ` Alex
2017-10-08  7:44               ` Eli Zaretskii
2017-10-09  0:06                 ` Alex
2017-10-05 19:02 ` Eli Zaretskii
2017-10-05 19:44   ` Robert Weiner
2017-10-05 19:58     ` Eli Zaretskii
2017-10-05 21:34       ` Robert Weiner
2017-10-06  3:09       ` Matthew Plant
2017-10-06  7:26         ` Eli Zaretskii [this message]
2017-10-06  7:50           ` Matthew Plant
2017-10-06  8:16             ` Eli Zaretskii
2017-10-06 12:37               ` Stefan Monnier
2017-10-06 13:06                 ` Eli Zaretskii
2017-10-06 13:25                   ` John Wiegley
2017-10-06 14:17                     ` Eli Zaretskii
2017-10-06 18:47                       ` John Wiegley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834lrcwxd0.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=maplant95@gmail.com \
    --cc=rswgnu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).