From: Eli Zaretskii <eliz@gnu.org>
To: Karl Fogel <kfogel@red-bean.com>
Cc: emacs-devel@gnu.org, juri@linkov.net
Subject: Re: [Emacs-diffs] master b88e7c8: Make transpose-regions interactive (Bug#30343)
Date: Thu, 29 Mar 2018 14:38:15 +0300 [thread overview]
Message-ID: <834lkzdsd4.fsf@gnu.org> (raw)
In-Reply-To: <87r2o3pjmm.fsf@red-bean.com> (message from Karl Fogel on Wed, 28 Mar 2018 23:53:53 -0500)
> From: Karl Fogel <kfogel@red-bean.com>
> Date: Wed, 28 Mar 2018 23:53:53 -0500
> Cc: emacs-devel@gnu.org
>
> >(put 'transpose-regions
> > 'interactive-form
> > '(if (< (length mark-ring) 2)
> > (error "Other region must be marked before transposing two regions")
> > (let* ((num (if current-prefix-arg
> > (prefix-numeric-value current-prefix-arg)
> > 0))
> > (ring-length (length mark-ring))
> > (eltnum (mod num ring-length))
> > (eltnum2 (mod (1+ num) ring-length)))
> > (list (point) (mark) (elt mark-ring eltnum) (elt mark-ring eltnum2)))))
>
> Personally, I think I'd prefer to have the interactive form together with the rest of the function definition, even if that's in C.
I agree. My reason is that this separation makes finding all the
pieces of the puzzle significantly harder.
> What would you think of mentioning this trick in doc/lispref/internals.texi, in the text for "@item interactive"?
The property is already prominently described, so just a
cross-reference to one of those places should be enough.
next prev parent reply other threads:[~2018-03-29 11:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180311105533.30002.78782@vcs0.savannah.gnu.org>
[not found] ` <20180311105534.3DAFD23CF3@vcs0.savannah.gnu.org>
2018-03-11 16:05 ` [Emacs-diffs] master b88e7c8: Make transpose-regions interactive (Bug#30343) Stefan Monnier
2018-03-11 17:23 ` Charles A. Roelli
2018-03-12 9:56 ` Leo Liu
2018-03-11 18:13 ` Eli Zaretskii
2018-03-15 20:20 ` Richard Copley
2018-03-16 15:23 ` Karl Fogel
2018-03-20 21:33 ` Karl Fogel
2018-03-20 21:46 ` Richard Copley
2018-03-21 7:22 ` Eli Zaretskii
2018-03-22 5:30 ` Karl Fogel
2018-03-22 7:12 ` Eli Zaretskii
2018-03-22 7:15 ` Unnecessarily moving stiff between files considered harmful (Was: [Emacs-diffs] master b88e7c8: Make transpose-regions interactive) (Bug#30343) Eli Zaretskii
2018-03-23 18:03 ` Unnecessarily moving stiff between files considered harmful Karl Fogel
2018-03-22 13:39 ` [Emacs-diffs] master b88e7c8: Make transpose-regions interactive (Bug#30343) Stefan Monnier
2018-03-23 18:05 ` Karl Fogel
2018-03-25 10:03 ` Charles A. Roelli
2018-03-25 15:41 ` Eli Zaretskii
2018-03-25 20:29 ` Charles A. Roelli
2018-03-26 15:59 ` Eli Zaretskii
2018-03-28 20:19 ` Juri Linkov
2018-03-29 4:53 ` Karl Fogel
2018-03-29 11:38 ` Eli Zaretskii [this message]
2018-03-29 12:17 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834lkzdsd4.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=juri@linkov.net \
--cc=kfogel@red-bean.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).